cookiecutter main: apply pyroject toml stuff#49
Merged
mberz merged 2 commits intomain_cookiecutterfrom May 16, 2025
Merged
Conversation
ahms5
added
documentation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request switches the packaging configuration from setup.py to a modern pyproject.toml‑based setup while updating CI/CD configurations.
- Removed setup.py in favor of pyproject.toml
- Updated dependency management and optional dependency groups in pyproject.toml
- Adjusted CI configurations in .circleci/config.yml and .readthedocs.yml for newer Python versions and build processes
Reviewed Changes
Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Removed in favor of a pyproject.toml‑based configuration |
| pyproject.toml | Introduces project metadata and dependency management via TOML |
| README.md | Minor updates to badges and heading formatting |
| .readthedocs.yml | Updated Python version and installation method for docs |
| .circleci/config.yml | Updated dependency installation commands and Python version support |
Files not reviewed (4)
- CONTRIBUTING.rst: Language not supported
- pytest.ini: Language not supported
- requirements_dev.txt: Language not supported
- setup.cfg: Language not supported
mberz
requested changes
Apr 24, 2025
README.md
Outdated
|
|
||
| [](https://badge.fury.io/py/pyrato) | ||
| [](https://pyrato.readthedocs.io/en/stable/?badge=stable) | ||
| [](https://pyrato.readthedocs.io/en/latest/?badge=latest) |
Member
There was a problem hiding this comment.
This should link to stable, which is the most recent version tag, not latest, which is the latest git commit on the default branch.
ahms5
commented
Apr 24, 2025
mberz
approved these changes
Apr 25, 2025
github-project-automation
bot
moved this from Require review
to Reviewer Approved
in Weekly Planning
f-brinkmann
approved these changes
May 9, 2025
Member
f-brinkmann
left a comment
f-brinkmann
left a comment
There was a problem hiding this comment.
Approving this - but I would suggest to make a separate pull for removing Python 3.8 support because its also dropped in pyfar
github-project-automation
bot
moved this from Reviewer Approved
to Done
in Weekly Planning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merges into #48 in addition the #48 it changes to pyproject.toml setup
Changes proposed in this pull request: