Skip to content

V1 api docs#64

Merged
mberz merged 10 commits intopyfar:develop_1.0.0from
sbch22:v1-API_docs
Aug 15, 2025
Merged

V1 api docs#64
mberz merged 10 commits intopyfar:develop_1.0.0from
sbch22:v1-API_docs

Conversation

@sbch22
Copy link
Copy Markdown
Contributor

@sbch22 sbch22 commented Aug 8, 2025

Which issue(s) are closed by this pull request?

API references adjusted for v_1.0.0

Changes proposed in this pull request:

  • removed pyrite.rst from docs/modules/
  • added missing dip.rst, etc.rst, parameters.rst & parametric.rst to docs/modules

Copy link
Copy Markdown
Member

@hoyer-a hoyer-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looking good!
In the other packages, the module page titles are like their import paths (e.g., pyrato.dsp). That's also what appears in the left sidebar.

Maybe change it for consistency, also for analytic.

@mberz mberz moved this from Backlog to Implementation in progress in Weekly Planning Aug 11, 2025
@mberz mberz added this to the v1.0.0 milestone Aug 11, 2025
@mberz mberz added the documentation Improvements or additions to documentation label Aug 11, 2025
Copy link
Copy Markdown
Member

@ahms5 ahms5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for taking care. I would add to the comments from @hoyer-a please make sure that the doc is building without any warnings.

@sbch22
Copy link
Copy Markdown
Contributor Author

sbch22 commented Aug 12, 2025

The structure is adjusted for analytic submodule. All warnings from the compilation are taken care of. Only two from the example code reside but I will take care of those another day.

@f-brinkmann
Copy link
Copy Markdown
Member

The structure is adjusted for analytic submodule. All warnings from the compilation are taken care of. Only two from the example code reside but I will take care of those another day.

Are they coming from code that you touched? If inot, it should be fixed in a different pull. We try to be strict about that to make the pulls smaller, and easier to review.

@sbch22
Copy link
Copy Markdown
Contributor Author

sbch22 commented Aug 12, 2025

The structure is adjusted for analytic submodule. All warnings from the compilation are taken care of. Only two from the example code reside but I will take care of those another day.

Are they coming from code that you touched? If inot, it should be fixed in a different pull. We try to be strict about that to make the pulls smaller, and easier to review.

No they are in the example code in the docstrings. So they are from an earlier iteration.

Copy link
Copy Markdown
Member

@ahms5 ahms5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks fine, in my opinion we are almost there. I dont see any other warinings anymore. you can simply check locally:

make html SPHINXOPTS="-W"

@@ -0,0 +1,7 @@
pyrato.analytic.impedance
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete

@@ -0,0 +1,7 @@
pyrato.analytic.analytic
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete,
we dont need this level of detail, this subdevision of the analytic model is just internally. From extern you still call all funtions from analytic. e.g. pyrato.analytic.rectangular_room_rigid_walls which is in analytic.py or pyrato.analytic.rectangular_room_impedance from impedance.py. The documentaiton should habe the same style

@github-project-automation github-project-automation bot moved this from Implementation in progress to Require review in Weekly Planning Aug 12, 2025
sbch22 and others added 2 commits August 13, 2025 11:55
Co-authored-by: Anne Heimes <64446926+ahms5@users.noreply.github.com>
@sbch22
Copy link
Copy Markdown
Contributor Author

sbch22 commented Aug 13, 2025

thanks, looks fine, in my opinion we are almost there. I dont see any other warinings anymore. you can simply check locally:

make html SPHINXOPTS="-W"

Thanks! Two warnings are being put out upon compilation but they stem from the internal python examples in the Docstrings. In that case this would be a new PR I think

...
updating environment: [new config] 12 added, 0 changed, 0 removed
:13: UserWarning: The figure layout has changed to tight
:12: UserWarning: The figure layout has changed to tight
...

Copy link
Copy Markdown
Member

@mberz mberz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I currently cannot trigger the circleci test manually, but they should start if there's another commit on this PR.

The mentioned issues can be taken care of in a separate PR

@mberz mberz requested a review from ahms5 August 15, 2025 12:24
@mberz mberz merged commit 6371409 into pyfar:develop_1.0.0 Aug 15, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from Require review to Done in Weekly Planning Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants