v1.0.0 parameter clarity by sbch22 · Pull Request #66 · pyfar/pyrato

sbch22 · 2025-09-05T11:26:39Z

Changes proposed in this pull request:

implements clarity in pyrato.parameters
implements respective tests

ahms5

Thank you for your implementation. looks already good in general, this are mostly very small comments. looks linke you need to merge develop_1.0.0 into your branch, so that the automatied test are also running.

pyrato/parameters.py

tests/test_parameters_clarity.py

pyrato/parameters.py

tests/test_parameters_clarity.py

…lution added.

…hannel_shape() Co-authored-by: Anne Heimes <64446926+ahms5@users.noreply.github.com>

…rce comment Co-authored-by: Anne Heimes <64446926+ahms5@users.noreply.github.com>

Co-authored-by: Anne Heimes <64446926+ahms5@users.noreply.github.com>

mberz

Thanks for implementing.
I have a two major comment on the need for normalization, which I think we should get rid of.
The docstring and implementation disagree if the output is logarithmic or not.
The remaining comments are mostly minor.

pyrato/parameters.py

tests/test_parameters_clarity.py

pyrato/parameters.py

…alised EDCs, testing, and additional tests

f-brinkmann

Did not check the tests in detail 🙈

pyrato/parameters.py

tests/test_parameters_clarity.py

…t removed, edc cleanup changed

f-brinkmann

Only three suggestions for avoiding lines with over length. Otherwise approved.

pyrato/parameters.py

Co-authored-by: Fabian Brinkmann <fabian.brinkmann@mailbox.org>

mberz

Only docstring comments. ;)

pyrato/parameters.py

Co-authored-by: Marco Berzborn <mberz@users.noreply.github.com>

sbch22 added this to Weekly Planning Sep 5, 2025

github-project-automation bot moved this to Backlog in Weekly Planning Sep 5, 2025

sbch22 moved this from Backlog to Implementation in progress in Weekly Planning Sep 5, 2025

ahms5 added this to the v1.0.0 milestone Sep 9, 2025

ahms5 added the enhancement New feature or request label Sep 9, 2025

sbch22 requested a review from mberz September 11, 2025 10:15

sbch22 added the v1.0.0 label Sep 11, 2025

sbch22 self-assigned this Sep 11, 2025

sbch22 requested review from ahms5 and artur-pa September 12, 2025 12:41

ahms5 requested changes Sep 14, 2025

View reviewed changes

github-project-automation bot moved this from Implementation in progress to Require review in Weekly Planning Sep 14, 2025

sbch22 added 9 commits September 18, 2025 11:06

clarity WIP implemented. Tests in development.

d55aff2

parameters.clarity tests inital

93d457d

parameters.clarity implemented

a1f78f8

tests adjusted for clarity calculation from edc, test for analytic so…

2a22d14

…lution added.

clarity calculation adjusted to be solved from edc.

4ad6250

renamed early_time_limit to te (normative)

60817dc

Docstring example code adjusted to calculation directly from edc

c2414cd

minor linting

72990f2

obsolete test_data deleted

be6e007

sbch22 force-pushed the v1-parameter-clarity branch from cda2fbb to be6e007 Compare September 18, 2025 09:07

sbch22 and others added 5 commits September 18, 2025 11:17

Update tests/test_parameters_clarity.py test_clarity_preserves_multic…

79bca37

…hannel_shape() Co-authored-by: Anne Heimes <64446926+ahms5@users.noreply.github.com>

Update tests/test_parameters_clarity.py test_clarity_from_truth() sou…

631c826

…rce comment Co-authored-by: Anne Heimes <64446926+ahms5@users.noreply.github.com>

Update tests/test_parameters_clarity.py added ratio test

78a4dd7

Co-authored-by: Anne Heimes <64446926+ahms5@users.noreply.github.com>

Update pyrato/parameters.py simplification to vectored numpy operation

1271c58

Co-authored-by: Anne Heimes <64446926+ahms5@users.noreply.github.com>

implemented requested changes

1975f64

mberz requested changes Sep 18, 2025

View reviewed changes

sbch22 added 2 commits September 18, 2025 17:07

suggested changes implemented, including snake_case linting, non-norm…

c83117b

…alised EDCs, testing, and additional tests

raw docstring because of backslashes

3f52231

Userwarning stacklevel specified, small fixes

4a5fdeb

sbch22 requested review from ahms5 and mberz September 18, 2025 15:48

f-brinkmann requested changes Sep 18, 2025

View reviewed changes

sbch22 added 5 commits September 23, 2025 20:38

ruff linting, proposed changes

e780093

ruff linting, Fomula in Docstring modified

1086dc0

/right added in docstring formula

c759e71

reference adjusted to rt style, minor style adjustments

b4f0fac

references specified

c2a1f20

sbch22 requested a review from a team September 23, 2025 19:35

sbch22 added 3 commits September 26, 2025 10:29

requested changes: no unusual early time limit warning, according tes…

a213857

…t removed, edc cleanup changed

wording in docstring changed

825f187

removed unused "warnings" import

16036fd

f-brinkmann requested changes Sep 26, 2025

View reviewed changes

pyrato/parameters.py Outdated Show resolved Hide resolved

pyrato/parameters.py Outdated Show resolved Hide resolved

pyrato/parameters.py Outdated Show resolved Hide resolved

sbch22 and others added 3 commits September 26, 2025 11:07

Update pyrato/parameters.py line overlength

991761c

Co-authored-by: Fabian Brinkmann <fabian.brinkmann@mailbox.org>

Update pyrato/parameters.py line overlength

af8ccd5

Co-authored-by: Fabian Brinkmann <fabian.brinkmann@mailbox.org>

Update pyrato/parameters.py line overlength

d3939b2

Co-authored-by: Fabian Brinkmann <fabian.brinkmann@mailbox.org>

f-brinkmann self-requested a review September 26, 2025 12:04

f-brinkmann approved these changes Sep 26, 2025

View reviewed changes

mberz requested changes Sep 26, 2025

View reviewed changes

pyrato/parameters.py Outdated Show resolved Hide resolved

pyrato/parameters.py Outdated Show resolved Hide resolved

pyrato/parameters.py Outdated Show resolved Hide resolved

pyrato/parameters.py Outdated Show resolved Hide resolved

pyrato/parameters.py Outdated Show resolved Hide resolved

sbch22 and others added 5 commits September 29, 2025 12:04

Update pyrato/parameters.py

4f95b25

Co-authored-by: Marco Berzborn <mberz@users.noreply.github.com>

Docstring beauty

6c1c9b2

Co-authored-by: Marco Berzborn <mberz@users.noreply.github.com>

Update pyrato/parameters.py

566ede9

Co-authored-by: Marco Berzborn <mberz@users.noreply.github.com>

Update pyrato/parameters.py

4eb98c9

Co-authored-by: Marco Berzborn <mberz@users.noreply.github.com>

Docstring edits

caaa707

sbch22 requested a review from mberz September 29, 2025 10:17

Docstring edit minor

303cdd7

mberz approved these changes Sep 30, 2025

View reviewed changes

mberz merged commit 2b38663 into pyfar:develop_1.0.0 Sep 30, 2025
12 checks passed

github-project-automation bot moved this from Require review to Done in Weekly Planning Sep 30, 2025

Conversation

sbch22 commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes proposed in this pull request:

Uh oh!

ahms5 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mberz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

f-brinkmann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

f-brinkmann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mberz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sbch22 commented Sep 5, 2025 •

edited

Loading

ahms5 left a comment •

edited

Loading