Conversation
ahms5
requested changes
Dec 19, 2025
Member
ahms5
left a comment
ahms5
left a comment
There was a problem hiding this comment.
nice, thank you, only minor comments
tests/test_copier.py
Outdated
| 'description = "my_project_short_description"', | ||
| 'requires-python = ">=3.11"', | ||
| "'acoustics',", | ||
| "'pyfar'", |
Member
There was a problem hiding this comment.
Suggested change
| "'pyfar'", | |
| "\n 'pyfar',\n", |
maybe also check if the indent is corret. This could also be applied to other paramters
ahms5
approved these changes
Jan 9, 2026
tests/test_copier.py
Outdated
Comment on lines
+82
to
+97
| for desired in ( | ||
| 'name = "my_project"', | ||
| 'version = "0.1.0"', | ||
| 'description = "my_project_short_description"', | ||
| 'requires-python = ">=3.11"', | ||
| '\n "acoustics",\n', | ||
| '\n "pyfar",\n', | ||
| '\n "numpy",\n', | ||
| '\n "scipy",\n', | ||
| '"License :: OSI Approved :: MIT License"', | ||
| 'Programming Language :: Python :: 3.11', | ||
| 'Programming Language :: Python :: 3.12', | ||
| 'Programming Language :: Python :: 3.13', | ||
| 'Programming Language :: Python :: 3.14', | ||
| 'Tracker = "https://github.com/pyfar/my_project/issues"', | ||
| ): |
Member
There was a problem hiding this comment.
this can be parametrized using pytest after #17 is merged.
h-chmeruk
force-pushed
the
add-pyproject.toml
branch
from
2393f92 to
3b960f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) are closed by this pull request?
Closes #13
Changes proposed in this pull request:
pyproject.tomlto the template directory.pyproject.tomlfile, updated thetest_generated_file_exists()function.copier.yml:project_short_description,version,keywords,pypi_license_classifiers_list,pypi_license_classifier