Conversation
ahms5
left a comment
ahms5
left a comment
There was a problem hiding this comment.
Thanks hanna, i have a few comments
| @@ -0,0 +1,49 @@ | |||
| name: 🐞 Bug report | |||
There was a problem hiding this comment.
| name: 🐞 Bug report | |
| name: Bug report |
it was annoying me, the others dont have an icon :D
| label: Is there an existing issue for this? | ||
| description: Please search to see if an issue already exists for the bug you encountered. | ||
| options: | ||
| - label: I have searched the existing issues |
There was a problem hiding this comment.
| - label: I have searched the existing issues | |
| - label: I looked for [similar issues](https://github.com/{{ git_username }}/{{ project_slug }}/issues). |
maybe adapt similar to the question
| options: | ||
| - label: I searched the [documentation](https://{{ project_slug }}.readthedocs.io). | ||
| required: true | ||
| - label: I looked through existing [discussion topics](https://github.com/pyfar/{{ project_slug }}/discussions). |
There was a problem hiding this comment.
| - label: I looked through existing [discussion topics](https://github.com/pyfar/{{ project_slug }}/discussions). | |
| - label: I looked through existing [discussion topics](https://github.com/{{ git_username }}/{{ project_slug }}/discussions). |
| required: true | ||
| - label: I looked through existing [discussion topics](https://github.com/pyfar/{{ project_slug }}/discussions). | ||
| required: true | ||
| - label: I looked for [similar issues](https://github.com/pyfar/{{ project_slug }}/issues). |
There was a problem hiding this comment.
| - label: I looked for [similar issues](https://github.com/pyfar/{{ project_slug }}/issues). | |
| - label: I looked for [similar issues](https://github.com/{{ git_username }/{{ project_slug }}/issues). |
| description: > | ||
| Please make sure you check all these items before submitting your feature request. | ||
| options: | ||
| - label: There are [no similar issues or pull requests](https://github.com/pyfar/{{ project_slug }}/issues) for this yet. |
There was a problem hiding this comment.
| - label: There are [no similar issues or pull requests](https://github.com/pyfar/{{ project_slug }}/issues) for this yet. | |
| - label: There are [no similar issues or pull requests](https://github.com/{{ git_username }/{{ project_slug }}/issues) for this yet. |
There was a problem hiding this comment.
Thank you for the review!
There is also a link in 04-documentation.yml.jinja : https://pyfar-gallery.readthedocs.io/en/latest/examples.
I guess there's no point in replacing pyfar with {{ git_username }} in this link.
Should it stay as it is, or should I perhaps remove the link?
There was a problem hiding this comment.
I think it should be replaced where ever it appears. this prevents bugs that might come up later.
I would leave the https://pyfar-gallery.readthedocs.io/en/latest/examples like as it is
ahms5
added
enhancement
h-chmeruk
force-pushed
the
add-issue-template
branch
from
99ee055 to
f927f39
Compare
| def test_content_github_issue_template(default_project, file_name): | ||
| content = default_project.project_dir.joinpath(file_name).read_text() | ||
| desired = 'https://github.com/pyfar/my_project/issues' | ||
| assert desired in content, f"{desired!r} is not in content" |
There was a problem hiding this comment.
This function replaces the previous functions test_content_github_02_question() and test_content_github_03_feature_request() and additionally adds a check of the file .github/ISSUE_TEMPLATE/01-bug-report.yml.
github-project-automation
bot
moved this from Backlog
to Require review
in Weekly Planning
ahms5
left a comment
ahms5
left a comment
There was a problem hiding this comment.
looks fine to me, thanks. I would just remove the discussion point
| - label: I looked through existing [discussion topics](https://github.com/{{ git_username }}/{{ project_slug }}/discussions). | ||
| required: true |
There was a problem hiding this comment.
| - label: I looked through existing [discussion topics](https://github.com/{{ git_username }}/{{ project_slug }}/discussions). | |
| required: true |
we dont use discussions right now, so I would remove this point.
3 participants
Which issue(s) are closed by this pull request?
Closes #19
Changes proposed in this pull request:
tests/test_copier/test_generated_file_existsto check the correct creation of new files.