Open
Conversation
…pyproject.toml and test_copier.py files
ahms5
requested changes
Mar 3, 2026
copier.yml
Outdated
| type: str | ||
| help: | | ||
| Enter a comma-separated list of files, directories, or file patterns that Ruff should ignore. | ||
| default: "examples/," |
Member
There was a problem hiding this comment.
Suggested change
| default: "examples/," | |
| default: "" |
I would make the default as empty. we dont have the folder examples anymore, that seems to be a leftover from an oder version
ahms5
requested changes
Mar 15, 2026
template/pyproject.toml.jinja
Outdated
Comment on lines
+79
to
+82
| ".git", | ||
| "docs", | ||
| {%- for key in ruff_ignore.split(',') %} | ||
| "{{ key.strip() }}", |
Member
There was a problem hiding this comment.
Suggested change
| ".git", | |
| "docs", | |
| {%- for key in ruff_ignore.split(',') %} | |
| "{{ key.strip() }}", | |
| {%- for key in ruff_ignore.split(',') %} | |
| "{{ key.strip() }}", |
why not to define all excluedes with the parameter, this would make it more flexible.
sorry, I think I did not see it ealier.
Contributor
Author
There was a problem hiding this comment.
Oh, true, thanks! I didn't notice that either
copier.yml
Outdated
| type: str | ||
| help: | | ||
| Enter a comma-separated list of files, directories, or file patterns that Ruff should ignore. | ||
| default: "" |
Member
There was a problem hiding this comment.
Suggested change
| default: "" | |
| default: ".git,docs" |
tests/test_copier.py
Outdated
| 'Programming Language :: Python :: 3.13', | ||
| 'Programming Language :: Python :: 3.14', | ||
| 'Tracker = "https://github.com/pyfar/my_project/issues"', | ||
| '"docs",\n "examples/",', |
Member
There was a problem hiding this comment.
Suggested change
| '"docs",\n "examples/",', | |
| '".git",\n "docs/",', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) are closed by this pull request?
Closes #26
Changes proposed in this pull request:
ruff_ignoreto thecopier.ymlfile. This parameter can be used to define files, directories, or file patterns that should be ignored by Ruff.pyproject.toml.jinjafile to include the entries from theruff_ignoreparameter.test_content_pyproject()function to test correct include of the custom ignores.