Skip to content

Add a pull request template #44

Open
h-chmeruk wants to merge 2 commits intomainfrom
add-pull-request-template
Open

Add a pull request template #44
h-chmeruk wants to merge 2 commits intomainfrom
add-pull-request-template

Conversation

@h-chmeruk
Copy link
Copy Markdown
Contributor

@h-chmeruk h-chmeruk commented Mar 2, 2026

Which issue(s) are closed by this pull request?

Closes #32

Changes proposed in this pull request:

  • Added the .github/PULL_REQUEST_TEMPLATE.md file, inspired by the template from appium and a PR from pyrato.
  • Adjusted the test_generated_file_exists() test.

@h-chmeruk h-chmeruk added this to the v0.1.0 milestone Mar 2, 2026
@h-chmeruk h-chmeruk added the enhancement New feature or request label Mar 2, 2026
@h-chmeruk h-chmeruk moved this from Backlog to Require review in Weekly Planning Mar 2, 2026
@ahms5 ahms5 moved this from Require review to Agenda in Weekly Planning Apr 10, 2026
@ahms5 ahms5 moved this from Agenda to Require review in Weekly Planning Apr 10, 2026
@ahms5 ahms5 requested review from ahms5, hoyer-a, mberz and sikersten April 10, 2026 12:38
Copy link
Copy Markdown
Member

@hoyer-a hoyer-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Unless we get some automation for the project board going soon, we could also consider adding a checkbox for project management (e.g. Add to weekly planning > set status).

@h-chmeruk
Copy link
Copy Markdown
Contributor Author

@hoyer-a, thank you for the review! I like the idea of adding a checkbox for project management. So, if no one has any objections, I'll add it :)

@ahms5
Copy link
Copy Markdown
Member

ahms5 commented Apr 11, 2026

sounds good, in case we add an action, we can still remove it.

Copy link
Copy Markdown
Member

@ahms5 ahms5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a PR to intoduce automatic project assignment for issues and prs #60, so maybe it is not required anymore

@hoyer-a
Copy link
Copy Markdown
Member

hoyer-a commented Apr 15, 2026

The automatic project assignment is great! Should we still put in a checkbox for the project board (correct status, priority etc.)?
I guess the automation will put PRs in the backlog, which we don't check that often.

mberz pushed a commit that referenced this pull request Apr 16, 2026
### Which issue(s) are closed by this pull request?

related to #44 

### Changes proposed in this pull request:

- adds a action to automatically add a new pr or issue to our project.
- the token was already generated, so once it is merged it should work
- I also added this workflow to this package, to check that it really works, before we ship it to each repo

---------

Co-authored-by: Hanna Chmeruk <119290248+h-chmeruk@users.noreply.github.com>
@h-chmeruk h-chmeruk force-pushed the add-pull-request-template branch from 0b950bb to 353e4bb Compare April 16, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Require review

Development

Successfully merging this pull request may close these issues.

Add template for pull request

3 participants