Conversation
ahms5
left a comment
There was a problem hiding this comment.
thanks for catching, not sure of the quotes are the issue. see below:
| {% if 'libsndfile1' in apt_packages -%} | ||
| apt_packages: | ||
| - libsndfile1 |
There was a problem hiding this comment.
| {% if 'libsndfile1' in apt_packages -%} | |
| apt_packages: | |
| - libsndfile1 | |
| {% if 'libsndfile1' in apt_packages -%} | |
| apt_packages: | |
| - libsndfile1 |
I think the bug is the intent of apt_packages: it does not have any spaces in front, but two are requried.
There was a problem hiding this comment.
Oh, indeed, thank you for pointing that out!
I think the absence of quotation marks was also a major issue, at least that’s what the error message on ReadTheDocs said...
0fe9c08 to
7947e7a
Compare
ahms5
left a comment
There was a problem hiding this comment.
Thank you, I just noticed an other point, sorry for not mentioning it earlier,
| @pytest.mark.parametrize("desired", [ | ||
| '- libsndfile1', | ||
| "python: 3.14", | ||
| 'python: "3.14"', |
There was a problem hiding this comment.
maybe also add this in order to prevent that error in future.
| 'python: "3.14"', | |
| 'python: "3.14"', | |
| ' apt_packages:', |
| {% if 'libsndfile1' in apt_packages -%} | ||
| python: "{{ latest_python_version }}" | ||
| {% if 'libsndfile1' in apt_packages -%} | ||
| apt_packages: |
There was a problem hiding this comment.
Sorry, I did not see it earlier, I think we can loop through all apt_packages here in the list below. In this way every package in apt_packages will be installed, which is also the intended use.
ahms5
left a comment
There was a problem hiding this comment.
almost there, thank you, I think we should add a test for empty apt_packages. what do you think?
|
@ahms5, yeah, sounds good, I'll add it |
9153559 to
554c974
Compare
The test for Read the Docs failed in the PR#927 of the pyfar package because the python version in the tools in the
.readthedocs.ymlfile was not enclosed in quotation marks.Changes proposed in this pull request:
{{ latest_python_version }}in the quotation markstest_copier.pyfile