Merged
Conversation
ahms5
requested changes
Apr 15, 2026
Member
ahms5
left a comment
ahms5
left a comment
There was a problem hiding this comment.
nice, thank you. I have a few ideas to make our live easier.
| - run: | ||
| name: Sphinx | ||
| command: | | ||
| {%- if add_submodules == true %} |
Member
There was a problem hiding this comment.
maybe add this as a separate block as done for the other ci jobs. Right now it is not that clean in sofar.
Contributor
Author
There was a problem hiding this comment.
Thank you for the review!
What exactly do you mean by a separate block? Could you please give an example?
h-chmeruk
force-pushed
the
add-submodules-parameter
branch
from
f0f4b71 to
c83e6d7
Compare
ahms5
requested changes
Apr 15, 2026
Comment on lines
+95
to
+101
| - run: | ||
| name: Sphinx | ||
| command: | | ||
| {%- if add_submodules == true %} | ||
| git submodule sync --recursive | ||
| git submodule update --recursive --init | ||
| {%- endif %} |
Member
There was a problem hiding this comment.
Suggested change
| - run: | |
| name: Sphinx | |
| command: | | |
| {%- if add_submodules == true %} | |
| git submodule sync --recursive | |
| git submodule update --recursive --init | |
| {%- endif %} | |
| {%- if add_submodules == true %} | |
| - run: | |
| name: synchronize submodules | |
| command: git submodule update --init --recursive && git submodule update --recursive --init | |
| {%- endif %} | |
| - run: | |
| name: Sphinx | |
| command: | |
sth like this? now the Sphinx is just excecuting installing dependencies and excecute Sphinx
Contributor
Author
There was a problem hiding this comment.
Oh yes, you're right, that would look much better, and we have already used that block in other places in the file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should cover the implementation of submodules introduced in the sofar package.
Changes proposed in this pull request:
.circleci/config.yml,CONTRIBUTING.rstand.readthedocs.ymlconftest.pyandtest_copier.pyto check for the existence of the new content