Skip to content

Support CatBoost in Python 3.13 #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 20, 2025
Merged

Support CatBoost in Python 3.13 #523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4dd5436
Update action.yml
akihironitta Apr 14, 2025
23bac3a
update
akihironitta Apr 14, 2025
ced7f3a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 14, 2025
299e11b
Merge branch 'master' into akihironitta-patch-2
akihironitta Apr 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .github/actions/setup/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,3 @@ runs:
python -c "import torch; print('PyTorch:', torch.__version__)"
python -c "import torch; print('CUDA:', torch.version.cuda)"
shell: bash

# TODO: Include catboost in Python 3.13 CI when catboost supports it:
# https://github.com/catboost/catboost/issues/2748
- name: Exclude catboost on Python 3.13 from pyproject.toml
if: ${{ inputs.python-version == '3.13' }}
run: |
sed -i '/ "catboost",/d' pyproject.toml
cat pyproject.toml
shell: bash
21 changes: 5 additions & 16 deletions test/gbdt/test_gbdt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import os.path as osp
import sys
import tempfile

import pytest
Expand All @@ -13,21 +12,11 @@
from torch_frame.testing.text_embedder import HashTextEmbedder


@pytest.mark.parametrize(
'gbdt_cls',
[
# TODO: Run CatBoost test on Python 3.13 once supported
# https://github.com/catboost/catboost/issues/2748
pytest.param(
CatBoost,
marks=pytest.mark.skipif(
sys.version_info >= (3, 13),
reason="Not supported on Python 3.13",
),
),
XGBoost,
LightGBM,
])
@pytest.mark.parametrize('gbdt_cls', [
CatBoost,
XGBoost,
LightGBM,
])
@pytest.mark.parametrize('stypes', [
[stype.numerical],
[stype.categorical],
Expand Down
Loading