Change relevant mouse event attributes to floats #2428
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for SDL3, where these attributes are floats. See SDL3 include: https://github.com/libsdl-org/SDL/blob/main/include/SDL3/SDL_events.h.
It would be un-ideal to get these attributes as floats and then cast them to ints before returning them to our users, just throwing away the precision. So we should get ready for the higher precision.
This is not 100% backwards compatible, somebody could be indexing an area with a mousemotion.pos for instance. But I think the vast majority of projects will be unaffected. Especially in Python3, where ints do floating division by default anyways. @ankith26 I'm curious if you think the MOUSEWHEEL change will be too disruptive? I feel like it's more of a change than the
pos
ones.