Renderer.blit rework.
#2623
Closed
Renderer.blit rework.
#2623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
IAProg
approved these changes
Apr 1, 2024
| if (<Image>source).texture.renderer != self: | ||
| raise TypeError("Source Image is not created by this Renderer") | ||
| elif isinstance(source, Surface): | ||
| source = Texture.from_surface(self, source) # Warning: slow |
There was a problem hiding this comment.
Warning: slow
This is an understatement if there ever was one. We should probably at least create a warning here. This kind of defeats the purpose of using renderer, and calling Texture.from_surface at the call site is not that much slower than doing it here.
I understand that this for convenience, but silently succeeding makes it hard to see what the problem is.
|
I think I'll close this. While there are some nice fixes in this PR, I agree with robertpfeiffer, surfaces should not be accepted here, and there are some conflicts too. I still see you around sometimes so if you have the time and energy, feel free to reopen this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renderer.blit()doesn't check if the texture is created by another renderer. #2622, now this function only accept Texture, Image, Surface and their subclasses.TextureorImagecreated from other Renderers is passed.Renderer.blitsupports Surface as source.