-
-
Notifications
You must be signed in to change notification settings - Fork 185
Add pygame.transform.bloom function #2872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
damusss
wants to merge
32
commits into
pygame-community:main
Choose a base branch
from
damusss:transform-bloom
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 15 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
fc76910
Add new API
damusss 27041bc
Rename int to char
damusss 20c91e4
Remove unused variable
damusss 287843f
Remove another unused variable
damusss 1119a28
Set default blur type to box
damusss 0e17e93
Remove smooth argument, fix memory leak, address formatting
damusss df4b90b
Remove cast
damusss 4bbe3ce
Fix format and docs
damusss 2241c7c
Disallow 16 bit surfaces
damusss d03e500
Update docs
damusss 014b629
Setup macro system for blur
damusss 792f74b
Fix and fasten bright pass filtering
damusss f38cd45
Performance/code improvement
damusss e6035b5
Another improvement
damusss a74d6c3
Small fix
damusss 5f922ae
Use a pixels-like buffer
damusss f6f2c24
Revert buffer, update docs, update arguments, add test
damusss 9d4d911
Generate docs
damusss 8d57023
Fix test
damusss c3f87ec
Add another test
damusss 7064f30
Add comment
damusss cd20518
Merge branch 'main' into transform-bloom
damusss dd0ea3a
Fix stubs
damusss 347e352
Update bytes per pixel with macro
damusss a875eda
docs
damusss 6019631
Merge branch 'pygame-community:main' into transform-bloom
damusss 937f7fc
Merge branch 'main' into transform-bloom
MyreMylar e0a5cba
fix documentation formatting
MyreMylar 402f775
Update versionadded
damusss de35cc4
Explain parameters in docs
damusss f42aea1
Fix docs indenting
damusss 0cf0a5f
Make it an actual parameter list
damusss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this section I think some details on the expected parameter ranges would be useful, particularly on the valid values for
blur_type
, which I believe aregaussian
andbox
. Without some guidance it is hard to know if values like 'intensity` should normally be in the range of 0-1000, or 0.0 to1.0.