Fix draw halting when using NaN argument#3467
Draft
MightyJosip wants to merge 4 commits intopygame-community:mainfrom
Draft
Fix draw halting when using NaN argument#3467MightyJosip wants to merge 4 commits intopygame-community:mainfrom
MightyJosip wants to merge 4 commits intopygame-community:mainfrom
Conversation
ankith26
reviewed
Jun 3, 2025
Member
ankith26
left a comment
ankith26
left a comment
There was a problem hiding this comment.
It would be nice if you added testcases for this
| return NULL; \ | ||
| } | ||
|
|
||
| #define CHECK_NAN(value) ((unsigned int)value == 0x80000000) |
Member
There was a problem hiding this comment.
I'd rather have something like isnan from math.h instead of this
Member
|
Hello, marking this as a draft because there are unresolved comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3412
When using NaN as argument, skip the drawing (of that part of function)