Add keywords and import-names to pyproject.toml#3630
Conversation
📝 WalkthroughWalkthroughTwo new project metadata fields added to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2025-10-08T08:15:01.411ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (17)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
this PR can potentially fix #2478 but it depends on whether PyCharm supports this metadata rn. It would be cool if some pycharm user were to test this PR. |
|
I'm extremely doubtful Pycharm would support this, it's pretty new. Do you need to update the metadata in setup.py as well? |
That won't be necessary. All our pypi wheels use |
|
Regardless, it would be good to keep them consistent while they both still exist. |
|
I'm marking this as a draft to make it clear that I think the next action is on you. Yes, we don't use setup.py for any release wheels, but I still think the metadata which is consistent in other ways should stay consistent in this way. |
|
I thought I had replied this on here already but somehow I forgot. Anyways, here is the current error I get, running turns out |
import-names: https://peps.python.org/pep-0794/I also took the opportunity to add the
keywordsmetadata, hopefully it improves pypi discoverability