-
Notifications
You must be signed in to change notification settings - Fork 8
Revamp #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp #106
Changes from 8 commits
15fd53b
e9a2f9d
575ba69
1877ab4
1c03d60
c9601fb
a1ad823
f4bf1b8
c463515
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,12 @@ | ||
name: Electron CI | ||
|
||
on: [push, pull_request] | ||
on: | ||
push: | ||
branches: | ||
main | ||
pull-request: | ||
branches: | ||
main | ||
|
||
jobs: | ||
build: | ||
|
This file was deleted.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,88 @@ | ||||||||||
--- | ||||||||||
layout: default | ||||||||||
title: What is Pygame | ||||||||||
next_page: [/guide/intro/chapter-2, Opening A Window] | ||||||||||
--- | ||||||||||
|
||||||||||
<body> | ||||||||||
<p>In this article, we'll go over what pygame is and how to install it.</p> | ||||||||||
|
||||||||||
<h2>Table of contents</h2> | ||||||||||
<p></p> | ||||||||||
<ol id="toc"> | ||||||||||
<!-- | ||||||||||
To be filled by javascript | ||||||||||
--> | ||||||||||
</ol> | ||||||||||
|
||||||||||
<h2><a id="introduction" class="js">Introduction</a></h2> | ||||||||||
<p> | ||||||||||
It's time to get started on your pygame journey, but what is pygame? Well | ||||||||||
pygame is "a free and open-source cross-platform library for the development | ||||||||||
of multimedia applications like video games using Python". As the | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You should cite where quotes come from, in this case, it's the pygame(-ce) github readme |
||||||||||
description suggests, it's mostly used to make video games - which is why in | ||||||||||
this book we'll be learning techniques relevant to making games | ||||||||||
</p> | ||||||||||
|
||||||||||
<p> | ||||||||||
Pygame provides the very basic utility to draw and manipulate pixels on to | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Grammar feels off here, have a suggestion
Suggested change
|
||||||||||
the screen, much like <a href="https://www.libsdl.org/">SDL2</a>, but with | ||||||||||
extended features in various forms that makes it easier to use. Given this | ||||||||||
nature, you generally have a lot of control on how you want your code to | ||||||||||
run, so it may have a bit of a learning curve. But fear not! After reading | ||||||||||
this book you should be able to use pygame just fine, as long as you get | ||||||||||
your practice in 🔫 | ||||||||||
</p> | ||||||||||
|
||||||||||
<p> | ||||||||||
In this book we'll aim to cover how to do basic things with pygame, with | ||||||||||
little exercises in between to make sure you're not falling off, goodluck | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the
Suggested change
|
||||||||||
</p> | ||||||||||
|
||||||||||
<h2><a id="pygame-ce" class="js">Pygame-CE</a></h2> | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This whole section makes a large number of bold claims, but doesn't provide any supporting evidence for it. I suggest instead linking to some external party dialogues and briefly summarizing the differences instead. The drama part is not really important to the average noob and I suspect the heavy bias here might rub people the wrong way There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Which ones?
Hmm, I think removing the last sentence might fix it: "It is recommended to use only
I don't really think I dwelt too deep into the drama, I just mentioned how pygame-ce was formed There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe this line Could be changed to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So this is how it would be now: pygame-ce is a fork of the original pygame, which got created due to all the active developers of the original project being banned by the "owner". The fork is not owned by any one person and follows a more democratic model to its management So what happened to all the active developers of the original pygame? They formed pygame-ce! That's right, so pygame-ce is being developed by the same people (and more) as the original pygame, and with a more democratic model have been able to push releases way more easily and introduce many more features. For all sane purposes, we will be using pygame-ce in this book and we advise the same. It has had more performance improvements, code features, and active development than the original pygame for a while now. |
||||||||||
<p> | ||||||||||
So pygame currently has two major distributors, the original one and a fork | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Starting a sentence with "So" feels wrong, suggest opening with something different.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I feel like this is too formal? In English it's valid to start sentences with "So" afaik. In formal writing it's frowned upon - but I was trying to go for a more friendly and engaging vibe for the whole article/book. This isn't necessarily unfriendly, of course, but I feel being too formal makes it less engaging |
||||||||||
of the project. What is a fork? Well it means it's a copy of the project, and | ||||||||||
in this case they branched off to be two completely separate packages now. | ||||||||||
</p> | ||||||||||
<p> | ||||||||||
<a href="https://github.com/pygame-community/pygame-ce">pygame-ce</a> is the | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nitpick: "a fork" |
||||||||||
fork of the original pygame, which got created due to all the active | ||||||||||
developers of the original project being banned by the "owner". Well, | ||||||||||
pygame-ce has no "owner", it follows a more democratic approach to managing | ||||||||||
itself now. | ||||||||||
</p> | ||||||||||
<p> | ||||||||||
So what happened to all the active developers of the original pygame? They | ||||||||||
formed pygame-ce! That's right, so pygame-ce is being developed by the same | ||||||||||
people (and more) as the original pygame, and with a more democratic model | ||||||||||
have been able to push releases way more easily and introduce many more | ||||||||||
features. | ||||||||||
</p> | ||||||||||
<p> | ||||||||||
For all sane purposes, we will be using <code>pygame-ce</code> in this book | ||||||||||
and we advise the same. It has had more performance improvements, code | ||||||||||
features, and active development than the original pygame for a while now. It | ||||||||||
is recommended to use only <code>pygame-ce</code> from now onwards by most | ||||||||||
Python communities. | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "most Python communities" There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pydis does push pygame-ce, yes. I'm not certain about r/python and r/learnpython to be honest, I'm not too sure that most Python communities infact do this - it was indeed a bold claim |
||||||||||
</p> | ||||||||||
|
||||||||||
<h2><a id="installation" class="js">Installation</a></h2> | ||||||||||
<p> | ||||||||||
Now that you know what pygame-ce is, let's install it. | ||||||||||
|
||||||||||
{% highlight python %} | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This doesn't need python syntax highlighting because it's not valid python code There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You're right, how do I make a simple codeblock without highlighting again? Just There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I figured it out, it was the |
||||||||||
pip uninstall pygame | ||||||||||
pip install pygame-ce | ||||||||||
{% endhighlight %} | ||||||||||
In order for pygame-ce to work, pygame needs to be uninstalled first. | ||||||||||
This is because both upstream pygame and pygame-ce share the import name, | ||||||||||
and so upstream pygame must be removed <u>first</u>. | ||||||||||
</p> | ||||||||||
<p> | ||||||||||
I simply included it as the first step in order to install pygame-ce in a foolproof manner with no issues, | ||||||||||
but I must remind you that a pre-requisite of using this site is knowing how to manage your | ||||||||||
environment, so please do learn that if you havent already | ||||||||||
</p> | ||||||||||
|
||||||||||
</body> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm gonna nitpick the alignment here