Skip to content

use _version.py - #56

Merged
Vipitis merged 9 commits into
mainfrom
_version
Jan 2, 2026
Merged

use _version.py#56
Vipitis merged 9 commits into
mainfrom
_version

Conversation

@Vipitis

@Vipitis Vipitis commented Sep 8, 2025

Copy link
Copy Markdown
Collaborator

this PR adds the shared infra, see: https://github.com/pygfx/_version

Comment thread pyproject.toml Outdated
@Vipitis
Vipitis requested a review from almarklein January 1, 2026 05:00

@almarklein almarklein left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Out of curiosity (and definitely not a blocker for this PR), have you considered using Flit for the build-system? It makes things a bit easier for simple (pure Python) packages.

@Vipitis

Vipitis commented Jan 2, 2026

Copy link
Copy Markdown
Collaborator Author

have you considered using Flit for the build-system? It makes things a bit easier for simple (pure Python) packages.

honestly haven't looked yet, but had a bit of a fight with flit for the pyodide stuff a while ago and it had some limitations. But for this package it should be fine. Doesn't need anything complex (maybe if we include media files...) here and it makes sense to be in line with the other projects.

My hope is to get the keyboard and imgui branches cleaned up and merged in the next couple weeks and do another release, so will look into the build system then.

@Vipitis
Vipitis merged commit 9910da1 into main Jan 2, 2026
10 checks passed
@Vipitis
Vipitis deleted the _version branch January 2, 2026 21:51
@almarklein

almarklein commented Jan 2, 2026

Copy link
Copy Markdown
Member

so will look into the build system then

Also have a look at hatchling; we use that in wgpu-py. From what I understood when I looked into it, hatch is a more modern but flexible alternative to the somewhat older setuptools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants