Conversation
almarklein
left a comment
There was a problem hiding this comment.
LGTM!
Out of curiosity (and definitely not a blocker for this PR), have you considered using Flit for the build-system? It makes things a bit easier for simple (pure Python) packages.
honestly haven't looked yet, but had a bit of a fight with flit for the pyodide stuff a while ago and it had some limitations. But for this package it should be fine. Doesn't need anything complex (maybe if we include media files...) here and it makes sense to be in line with the other projects. My hope is to get the keyboard and imgui branches cleaned up and merged in the next couple weeks and do another release, so will look into the build system then. |
Also have a look at hatchling; we use that in wgpu-py. From what I understood when I looked into it, hatch is a more modern but flexible alternative to the somewhat older setuptools. |
this PR adds the shared infra, see: https://github.com/pygfx/_version