Conversation
This reverts commit d2464b7.
Vipitis
marked this pull request as ready for review
December 1, 2025 20:07
Collaborator
Author
|
CI failure is related to #57 and the changes to the Shadertoy.com website like cloudflare ddos protection. The easiest solution would be to just package the texture (and other media) or provide an alternative source. However I am not sure what the individual copyright is for these files. We can also hope that embedding, API and perhaps media becomes available in the near future again. Generally there should be some fallback for offline use. Maybe we could include a cache filling command for the cli, but feels convoluted. In general I also want to make using Shadertoy media more user friendly by letting users create channels using the name. For example all three variants could be made to work: shader = Shadertoy(my_code, inputs=["Bayer", ShadertoyChannel("Font 1"), ShadertoyChannelTexture("Lichen")] |
Korijn
approved these changes
Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding motivation to work on this project some more.
Couple of improvements from upstream advancements:
wgpu.structsuse auto layout: currently breaks two examples, likely due to how we attach stubs for unused inputs.Perhaps it's not for our usecase: https://www.w3.org/TR/webgpu/#default-pipeline-layout -> the built auto layout is smarter than our input detection, but we can't access it's entries -.- so I will revert this commituse push constantspostponed to a different PR, as there is some native only features, but also idl features: https://gpuweb.github.io/gpuweb/wgsl/#pipeline-overridable hopefully included with wgpu release by end of year: Immediates tracking issue gfx-rs/wgpu#8556