Use new default device - #60
Merged
Merged
Conversation
almarklein
approved these changes
Mar 27, 2026
almarklein
left a comment
almarklein
left a comment
Member
There was a problem hiding this comment.
LGTM, but one CI job is failing.
Collaborator
Author
|
looks like a few pixels changed,.maybe due to the new rendercanvas approach? I will replace the reference when I am back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the default device from recent wgpu-py release.
Also had to make some changes for offscreen rendercanvas returning a numpy array.
To see where this might come in useful: pygfx/pygfx#1257
I am not sure if always requesting features is what I want. Perhaps
float32-filterableis widely available.If we only ever use the same global device, we could can also simplify remove some of the
._deviceproperties inpasses.py