Skip to content

Add examples for instance extras - #728

Closed
Vipitis wants to merge 25 commits into
pygfx:mainfrom
Vipitis:dxc
Closed

Add examples for instance extras#728
Vipitis wants to merge 25 commits into
pygfx:mainfrom
Vipitis:dxc

Conversation

@Vipitis

@Vipitis Vipitis commented Jul 23, 2025

Copy link
Copy Markdown
Contributor

This was mentioned in reply #718 (review)

PR adds two examples regarding instance extras:

  • Using DXC(over FXC) on Windows, includes a script to download the required library files.
  • Debugging using a graphics debugger like RenderDoc, includes a portable variant with a .cap file: works when your OS is setup to open .cap file with RenderDoc. Adds annotation and labels to the cube example.
  • documents the function in docs.

todos:

  • insert debug markers for the example
  • add labels to the example so they show up during debugging
  • fix more typos
  • add hyperlinks to other parts of the docs
  • update guide docs debug section?
  • file issue with Dxc not using debug flags in wgpu-core (perhaps in v26?) ref: unable to get debug flags with Dxc gfx-rs/wgpu-native#487
  • resolve arch, if needed?

@Vipitis

Vipitis commented Jul 27, 2025

Copy link
Copy Markdown
Contributor Author

while renderdoc has a python api, it's complex to build and package with modern python versions. So this might look like a workaround but I feel like that is actually quite convenient to use... making it work on linux sounds plausible.

Comment thread examples/extras_debug.py Outdated
Comment thread examples/cube.py Outdated
Comment thread examples/cube.py Outdated
@Vipitis
Vipitis marked this pull request as ready for review August 9, 2025 21:06
@Vipitis
Vipitis requested a review from Korijn as a code owner August 9, 2025 21:07
Comment thread examples/extras_debug.py Outdated
Comment thread examples/extras_debug.py Outdated
Comment thread examples/cube.py Outdated
Comment thread examples/extras_debug.py
almarklein
almarklein previously approved these changes Aug 28, 2025
@Vipitis Vipitis mentioned this pull request Sep 14, 2025
11 tasks
@Vipitis

Vipitis commented Sep 26, 2025

Copy link
Copy Markdown
Contributor Author

this is quite a messy branch with the changes to the example on main... is there still interest to have the other parts of the PR (examples, docs, download scripts).

I can fix the the extra bind group nesting and labels for the cube example in a different PR which should be a bit easier.

@almarklein

Copy link
Copy Markdown
Member

The conflicts in cube.py don't look too bad ... but ok if you want to contribute parts of this PR in pieces if that's easier!

@Vipitis

Vipitis commented Oct 4, 2025

Copy link
Copy Markdown
Contributor Author

I think I broke it more by trying to be clever... will try again tomorrow.

@Vipitis

Vipitis commented Oct 4, 2025

Copy link
Copy Markdown
Contributor Author

the branch in #760 should merge correctly

@Vipitis Vipitis closed this Oct 4, 2025
@Vipitis
Vipitis deleted the dxc branch October 6, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants