Fix ImguiRenderer and simplify gui callback function - #730
Merged
Conversation
kushalkolar
reviewed
Aug 6, 2025
Korijn
reviewed
Aug 7, 2025
Korijn
previously approved these changes
Aug 7, 2025
Co-authored-by: Korijn van Golen <korijn@gmail.com>
Korijn
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an occasional issue in
ImguiRendererthat could occur during window resizing. Specifically, we should obtain the frame's imguidraw_dataafter updatingbackend.io.display_size.In addition, we previously modified the API in #539 to introduce a GUI update hook function for ImguiRenderer. This hook can be further simplified—users should only need to write their GUI logic within the function, without having to include repetitive boilerplate code such as obtaining
draw_data.While this API change is not urgent—since modifying the interface could introduce compatibility issues for downstream projects—it’s a good opportunity to streamline the API, given the major update to ImGui v1.92 in #725 .