feat: Add sponsorship email notification to PSF accounting #241

ArnavBallinCode · 2025-11-01T12:18:52Z

Add PENDING_INVOICE status to SponsorshipProgressStatus
Create SponsorshipProfileDetail view for individual profile display
Add send-invoice functionality that updates status and emails PSF
Add email template for PSF accounting notifications
Update sponsorship table to include Send Invoice action button
Configure URLs for new detail and send-invoice endpoints
Update linting configuration to exclude .venv directory

Closes #170

- Add PENDING_INVOICE status to SponsorshipProgressStatus - Create SponsorshipProfileDetail view for individual profile display - Add send-invoice functionality that updates status and emails PSF - Add email template for PSF accounting notifications - Update sponsorship table to include Send Invoice action button - Configure URLs for new detail and send-invoice endpoints - Update linting configuration to exclude .venv directory Closes pyladies#170

netlify · 2025-11-01T12:18:55Z

✅ Deploy Preview for pyladiescon-portal-docs ready!

Name	Link
🔨 Latest commit	`d5d2914`
🔍 Latest deploy log	https://app.netlify.com/projects/pyladiescon-portal-docs/deploys/690981e0b06aa20008ce6a9d
😎 Deploy Preview	https://deploy-preview-241--pyladiescon-portal-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

- Add tests for send_psf_invoice_request_email function - Add tests for send_sponsorship_status_emails (pre-existing function) - Add tests for SponsorshipProfileDetail view - Add tests for SponsorshipProfileSendInvoice view - Verify email sending, status updates, and permission checks - Achieve 100% test coverage for sponsorship module

setup.cfg

…rations, .env/.venv, venv*, venv_local)

…tests Replace undefined LANGUAGES import from volunteer.models with volunteer.languages Keep VolunteerProfile imported from volunteer.models Fixes flake8 F821 error and lint failures

sponsorship/models.py

sponsorship/templates/sponsorship/email/psf_invoice_request.txt

Mariatta · 2025-11-02T20:39:30Z

One thing came to mind, and this can be done as a separate follow up ticket:

When switching the status into the "Approved" state, the company address, contact name and email should become required.
Don't know how complicated this is to implement. I think the field in the database level should remain optional, it's just the form entry that needs to validate that these values exists.
This is because these fields are required before the contract and invoice can be generated. If this sounds a lot, we can skip it for now and iterate on it later.

sponsorship/emails.py

Co-authored-by: Mariatta <[email protected]>

Mariatta · 2025-11-02T21:38:29Z

When switching the status into the "Approved" state, the company address, contact name and email should become required.

I've thought about this some more, and let's not bother with this requirement in this PR. For now we can assume that our sponsorship team will be entering these information correctly prior to clicking the send invoice button.

- Remove PENDING_INVOICE status as suggested (use APPROVED instead) - Convert email template to markdown format for HTML rendering - Add all required fields to PSF email (Company Address, Contact details) - Remove status update sentence from email template - Update send_invoice view to not change sponsorship status - Fix all references to PENDING_INVOICE in views and tests - Update email sending to use send_markdown_email helper

…update PSF email recipients test; apply formatting

sponsorship/emails.py

Mariatta

Great work. Thanks!

sponsorship/templates/sponsorship/sponsorship_profile_detail.html

- turn hardcoded email address into a constant values - Allow accepted volunteers to view sponsorship detail in readonly mode - Show sponsor logo in sponsor profile detail

Mariatta reviewed Nov 1, 2025

View reviewed changes

setup.cfg Outdated Show resolved Hide resolved

ArnavBallinCode added 3 commits November 2, 2025 18:40

chore: update flake8 exclude to ignore common virtualenv folders (mig…

0fe0e84

…rations, .env/.venv, venv*, venv_local)

fix(tests): import LANGUAGES from volunteer.languages in sponsorship …

2f3c73d

…tests Replace undefined LANGUAGES import from volunteer.models with volunteer.languages Keep VolunteerProfile imported from volunteer.models Fixes flake8 F821 error and lint failures

Merge branch 'main' into feature/sponsorship-email-psf-170

25863e3