Skip to content

feat: add pre-commit #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Mr-Sunglasses
Copy link
Contributor

issue: #3

  • add pre-commit, black, isort, etc

Copy link
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this. Just some minor wording suggestions.

Mr-Sunglasses and others added 3 commits April 7, 2025 10:45
Co-authored-by: Mariatta <[email protected]>
Co-authored-by: Mariatta <[email protected]>
Co-authored-by: Mariatta <[email protected]>
@Mr-Sunglasses
Copy link
Contributor Author

Thanks for starting this. Just some minor wording suggestions.

Thanks @Mariatta , I've done the suggested changes, Please review it again.

@Mariatta
Copy link
Member

Mariatta commented Apr 29, 2025

Thank you for the PR, but it doesn't seem to work for me. I'm getting error like

An error has occurred: InvalidManifestError:
==> File /.cache/pre-commit/repozoteah60/.pre-commit-hooks.yaml
==> At Hook(id='isort')
==> At key: stages
==> At index 0
=====> Expected one of commit, commit-msg, manual, merge-commit, post-checkout, post-commit, post-merge, post-rewrite, prepare-commit-msg, push but got: 'pre-commit'
Check the log at /.cache/pre-commit/pre-commit.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants