Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #36 -- Added Link to Terms of Service. #71

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed #36 -- Added Link to Terms of Service. #71

wants to merge 1 commit into from

Conversation

Phinart98
Copy link

Description

This PR addresses issue #36 by adding a required Terms of Service agreement checkbox to the signup form. Users must now agree to both the Terms of Service and Code of Conduct to complete the signup process.

Changes made

  • Added tos_agreement field to the PortalProfile model
  • Created migration for the new field
  • Added tos_agreement checkbox to the signup form
  • Updated the form to save both agreement values to the user's profile
  • Modified the coc_agreement field to include a link to the PyLadies Code of Conduct
  • Added link to the PSF Terms of Service
  • Updated tests to ensure both agreements are required for signup

How to test

  1. Start the application with make serve
  2. Go to the signup page
  3. Verify that both agreement checkboxes are present with working links
  4. Try to submit the form without checking the agreements (should fail)
  5. Complete the form with both agreements checked (should succeed)
  6. Verify in the admin that the agreements are saved to the user's profile

@Phinart98
Fixed pyladies#36 -- Added Link to Terms of Service.
b8d9716 
Added a required Terms of Service agreement checkbox to the signup
form alongside the existing Code of Conduct agreement. Updated the
PortalProfile model to store the user's agreement status. Both
agreements link to their respective external resources and are
required to complete the signup process.

Modified tests to ensure the new field is properly validated during
signup. The implementation follows the same pattern as the existing
Code of Conduct agreement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Phinart98