-
-
Notifications
You must be signed in to change notification settings - Fork 43
feat: Add validations for social media links in volunteer creation form #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Mr-Sunglasses could you resolve the conflicts please? |
👷 Deploy request for pyladiescon-portal-docs pending review.Visit the deploys page to approve it
|
Requesting @Mariatta for a review. |
Thanks for the PR! Great work. I think the validation logic will help a lot. |
There is now conflict due to the recent merge. |
Fixed, please review it again 😄 |
I think the changes you made with the input group got reverted during the merge. |
oh! I'll take a look at it and sync with the main branch. |
Test are failing |
Fixed the tests, please review it again cc. @Mariatta |
Sorry, there are more merge conflicts now because I merged several other PRs that touched the files. |
@Mariatta fix the conflicts, please review 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the thorough work. This is very helpful.
Thanks a lot, @Mariatta, for reviewing the PR during Pycon US's busy schedule. All the best for PyCon US. And again, thanks a lot for guiding. |
fix: #76