Skip to content

feat: Add validations for social media links in volunteer creation form #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 15, 2025

Conversation

Mr-Sunglasses
Copy link
Contributor

fix: #76

@Mariatta
Copy link
Member

@Mr-Sunglasses could you resolve the conflicts please?

Copy link

netlify bot commented May 3, 2025

👷 Deploy request for pyladiescon-portal-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 4bbcff1

@Mr-Sunglasses
Copy link
Contributor Author

@Mr-Sunglasses could you resolve the conflicts please?

Requesting @Mariatta for a review.

@Mariatta
Copy link
Member

Mariatta commented May 6, 2025

Thanks for the PR! Great work. I think the validation logic will help a lot.

@Mariatta
Copy link
Member

Mariatta commented May 6, 2025

There is now conflict due to the recent merge.

@Mr-Sunglasses
Copy link
Contributor Author

There is now conflict due to the recent merge.

Fixed, please review it again 😄

@Mariatta
Copy link
Member

Mariatta commented May 6, 2025

I think the changes you made with the input group got reverted during the merge.

@Mr-Sunglasses
Copy link
Contributor Author

I think the changes you made with the input group got reverted during the merge.

oh! I'll take a look at it and sync with the main branch.

@Mariatta
Copy link
Member

Mariatta commented May 6, 2025

Test are failing

@Mr-Sunglasses Mr-Sunglasses requested a review from Mariatta May 6, 2025 18:29
@Mr-Sunglasses
Copy link
Contributor Author

Test are failing

Test are failing

Fixed the tests, please review it again

cc. @Mariatta

@Mariatta
Copy link
Member

Mariatta commented May 8, 2025

Sorry, there are more merge conflicts now because I merged several other PRs that touched the files.

@Mr-Sunglasses
Copy link
Contributor Author

Sorry, there are more merge conflicts now because I merged several other PRs that touched the files.

@Mariatta fix the conflicts, please review 😄

Copy link
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the thorough work. This is very helpful.

@Mariatta Mariatta merged commit f214940 into pyladies:main May 15, 2025
2 checks passed
@Mr-Sunglasses
Copy link
Contributor Author

Thank you for the thorough work. This is very helpful.

Thanks a lot, @Mariatta, for reviewing the PR during Pycon US's busy schedule. All the best for PyCon US. And again, thanks a lot for guiding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add LinkedIn URL validation in volunteer creation form.
2 participants