feat: Add github action to run tests #78
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mariatta
reviewed
Apr 7, 2025
Member
Mariatta
left a comment
Mariatta
left a comment
There was a problem hiding this comment.
Thank you for starting this! I suggest using the make test and make migrate commands.
Co-authored-by: Mariatta <[email protected]>
Co-authored-by: Mariatta <[email protected]>
Contributor
Author
Thanks @Mariatta I've done the changes, think the tests action is failing because as these are no tests and it can't able to generate the report, apart from that I think we are good to go. |
Contributor
Author
|
requesting @Mariatta for a review |
Contributor
Author
|
@Mariatta I think this PR is good to go, we can merge it. |
✅ Deploy Preview for pyladiescon-portal-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
|
Thanks for the PR, but actually the tests were already done as part of the CI workflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #3