Skip to content

Kickgroup Improvements #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 23, 2025
Merged

Kickgroup Improvements #108

merged 3 commits into from
May 23, 2025

Conversation

@JoschD
Copy link
Member

@JoschD JoschD commented May 23, 2025 •
edited
Loading

While extracting kick data I noticed some inconsistencies and bugs with the kickgroup extraction.

Also adds JSON_FILE and FILL entries to the tfs summary tables

@JoschD JoschD self-assigned this May 23, 2025
@JoschD JoschD added Type: Bug Something isn't working as it should. Estimate: Normal Straightforward, but might require some time. Probably needs additional tests. Type: Maintenance Improvements in the code, that are not necessarily visible in functionality. Priority: Low Work on this if you have some spare time. labels May 23, 2025
@JoschD JoschD requested a review from fsoubelet May 23, 2025 12:39
fsoubelet
fsoubelet reviewed May 23, 2025
View reviewed changes
@JoschD JoschD merged commit 6d0bb76 into master May 23, 2025
19 of 21 checks passed
@JoschD JoschD deleted the kickgroups_improvement branch May 23, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fsoubelet fsoubelet fsoubelet approved these changes

Assignees

@JoschD JoschD

Labels

Estimate: Normal Straightforward, but might require some time. Probably needs additional tests. Priority: Low Work on this if you have some spare time. Type: Bug Something isn't working as it should. Type: Maintenance Improvements in the code, that are not necessarily visible in functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JoschD @fsoubelet