-
Notifications
You must be signed in to change notification settings - Fork 7
Bad BPM presentation #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad BPM presentation #163
Conversation
jgray-19
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the addition. It's good to know also what is done automatically to your data documented. So, looks good to me.
fsoubelet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few typos here and there. Two things though:
- I'm not sure we need the images in the website. I liked them in the slides but I'd like to keep the repo and builds small.
- I don't know if we should be introducing some new css for pages. Might be a lot at some point.
|
To your points: I agree with them in the sense, that I also thought about the same things, but decided to go this way because: a) The images are not needed, but I liked them and also reduced the larger ones in size and they are all <600KB. I think that is acceptable. b) the css colors are nice to have and the additional styles are named very specifically, so they should not interfer with anything else. I think they increase the points made in the text by sorting them into different analysis steps/topics. |
fsoubelet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No strong opinions on these points from me, all good to merge. Thanks
Added my presentation from today. What do you think?