Coverage Config #29
Merged
Coverage Config #29
+22
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoschD
reviewed
Oct 27, 2025
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
JoschD
reviewed
Oct 27, 2025
Member
Author
|
I'm scope creeping and adding the ascii reader to doc, which should close #26 |
JoschD
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding coverage config to
pyproject.tomlfrom a while ago that I'd never opened a PR for, apparently.This gives us a nicer output from the coverage run if we want details in the workflow itself. Also excludes lines which have no business being counted and can't be tested (all the TYPE_CHECKING blocks etc).
Could take this PR opportunity to fix the inconsistency in coverage threshold requirement too, since the last PR passed with flying colors but the workflow failed on master.