Skip to content

Add regression test for changes to support hermetic interpreters #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 16, 2022

Conversation

jacobtylerwalls
Copy link
Member

Steps

  • For new features or bug fixes, add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

Add a regression test for #1207.

Type of Changes

Type
⏪ Regression Test

Related Issue

Closes pylint-dev/pylint#5341
Alternative to pylint-dev/pylint#5210

Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @jacobtylerwalls. This has been a very long outstanding issue.

@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining astroid or the dev workflow label Feb 16, 2022
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.10.0 milestone Feb 16, 2022
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @jacobtylerwalls !

@Pierre-Sassoulas Pierre-Sassoulas merged commit a7d0a18 into pylint-dev:main Feb 16, 2022
@jacobtylerwalls jacobtylerwalls deleted the hermetic branch February 16, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add proper tests for the change to the module loader in astroid
3 participants