Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[used-before-assignment] Fix FP for inner function return type #10275

Merged
merged 3 commits into from
Mar 18, 2025
Merged

[used-before-assignment] Fix FP for inner function return type #10275

merged 3 commits into from
Mar 18, 2025

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

Closes #9391

@jacobtylerwalls jacobtylerwalls added False Positive 🦟 A message is emitted but nothing is wrong with the code C: used-before-assignment Issues related to 'used-before-assignment' check backport maintenance/3.3.x labels Mar 13, 2025
@jacobtylerwalls jacobtylerwalls added this to the 3.3.6 milestone Mar 13, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 95.86%. Comparing base (512c8be) to head (e93ec76).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #10275   +/-   ##
=======================================
  Coverage   95.86%   95.86%           
=======================================
  Files         175      175           
  Lines       19072    19074    +2     
=======================================
+ Hits        18284    18286    +2     
  Misses        788      788
Files with missing lines Coverage Ξ”
pylint/checkers/variables.py 97.28% <100.00%> (+<0.01%) ⬆️
πŸš€ New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
Pierre-Sassoulas
Pierre-Sassoulas reviewed Mar 17, 2025
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a nit.

@github-actions GitHub Actions
Copy link
Contributor

πŸ€– According to the primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

This comment was generated for commit e93ec76

@jacobtylerwalls jacobtylerwalls merged commit 78666e4 into main Mar 18, 2025
43 of 44 checks passed
@jacobtylerwalls jacobtylerwalls deleted the uba/return-annotation-nested-func branch March 18, 2025 12:02
github-actions bot pushed a commit that referenced this pull request Mar 18, 2025
@jacobtylerwalls @github-actions
[used-before-assignment] Fix FP for inner function return type (#10275)
028df3c 
(cherry picked from commit 78666e4)
@github-actions github-actions bot mentioned this pull request Mar 18, 2025
Merged
Pierre-Sassoulas pushed a commit that referenced this pull request Mar 18, 2025
@github-actions @jacobtylerwalls
[used-before-assignment] Fix FP for inner function return type (#10275)…
544464a 
… (#10285)

(cherry picked from commit 78666e4)

Co-authored-by: Jacob Walls <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
backport maintenance/3.3.x C: used-before-assignment Issues related to 'used-before-assignment' check False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Milestone
3.3.6
Development

Successfully merging this pull request may close these issues.

False positive used-before-assignment for type annotations in inner functions
2 participants
@jacobtylerwalls @Pierre-Sassoulas