Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: 49 failing pytests on PyPy 3.11 #10288

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Mar 19, 2025

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

Why recreate a venv and keep reactivating that venv at each job step when actions/setup-python already automatically does so?

Why keep dependencies in both pyproject.toml and multiple requirements_*.txt files which make cache key calculation complex?

Remove the complex cache gymnastics to see if pytests can pass on PyPy 3.11.

Refs #XXXX

Closes #10287
Closes #10286

The one failing pytest on PyPy3.9 and PyPy3.10 seems to be a full path vs. partial path difference.

- Using config file /opt/hostedtoolcache/PyPy/3.9.19/x64/lib/pypy3.9/site-packages/pylint/testutils/testing_pylintrc
+ Using config file pylint/testutils/testing_pylintrc

Which is minor but the 48 other failing pytests on PyPy3.11 seem to require attention.

Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 95.86%. Comparing base (62ac273) to head (d49764d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #10288   +/-   ##
=======================================
  Coverage   95.86%   95.86%           
=======================================
  Files         175      175           
  Lines       19074    19074           
=======================================
  Hits        18286    18286           
  Misses        788      788           
πŸš€ New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cclauss cclauss changed the title GitHub Actions: Fix failing PyPy tests GitHub Actions: 49 failing pytests on PyPy 3.11 Mar 19, 2025
Copy link
Contributor

πŸ€– According to the primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

This comment was generated for commit d49764d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant