-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Handle deferred evaluation of annotations in Python 3.14 #10381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
We should wait until we can test 3.14 in CI before merging this. I also don't really like that we need to duplicate a lot of tests. Maybe we can come up with a better solution for dealing conditional errors in our tests. |
This comment has been minimized.
This comment has been minimized.
Great !
Agree, so it's Blocked by pylint-dev/astroid#2731 and then the pylint equivalent.
Maybe time to design something to be able to expect something different according to the version ? something = 1 # [unused-variable|>=3.13,missing-module-docstring] With |
32635df
to
8615074
Compare
Explored something like this in #10382. The diff here would look much better, see 379ab07. |
8615074
to
379ab07
Compare
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 379ab07 |
Closes #10149