Skip to content

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

Closes #10660

@jacobtylerwalls jacobtylerwalls added this to the 4.0.1 milestone Oct 13, 2025
@jacobtylerwalls jacobtylerwalls added False Positive 🦟 A message is emitted but nothing is wrong with the code backport maintenance/4.0.x labels Oct 13, 2025
) or (
"EnumMeta"
in {
ancestor.name
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually check qname(), but I'm not so worried about that here. I need to look into whether the qname changed in python 3.14 anyway :/

@jacobtylerwalls jacobtylerwalls force-pushed the jtw/fp-invalid-name-enum branch from 25cb010 to a1463ca Compare October 13, 2025 23:16
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 95.96%. Comparing base (8fd96fa) to head (939d6a7).
⚠️ Report is 41 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #10661   +/-   ##
=======================================
  Coverage   95.96%   95.96%           
=======================================
  Files         176      176           
  Lines       19470    19525   +55     
=======================================
+ Hits        18684    18738   +54     
- Misses        786      787    +1     
Files with missing lines Coverage Ξ”
pylint/checkers/base/name_checker/checker.py 98.72% <100.00%> (ΓΈ)

... and 17 files with indirect coverage changes

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This comment has been minimized.

@jacobtylerwalls jacobtylerwalls force-pushed the jtw/fp-invalid-name-enum branch from a1463ca to 939d6a7 Compare October 14, 2025 00:27
Copy link
Contributor

πŸ€– Effect of this PR on checked open source code: πŸ€–

Effect on home-assistant:
The following messages are no longer emitted:

  1. invalid-name:
    Constant name "SsdpChange" doesn't conform to UPPER_CASE naming style
    https://github.com/home-assistant/core/blob/3c3b4ef14a247704d9aa02822b2748da792f6a60/homeassistant/components/ssdp/scanner.py#L62
  2. invalid-name:
    Constant name "BluetoothChange" doesn't conform to UPPER_CASE naming style
    https://github.com/home-assistant/core/blob/3c3b4ef14a247704d9aa02822b2748da792f6a60/homeassistant/components/bluetooth/models.py#L10

Effect on music21:
The following messages are no longer emitted:

  1. invalid-name:
    Constant name "ErrorLevel" doesn't conform to '(([A-Z_][A-Z0-9_])|(.*))$' pattern*
    https://github.com/cuthbertLab/music21/blob/e461154fce0d3675c78d73e847f73b9505561143/music21/volpiano.py#L45

Effect on sentry:
The following messages are no longer emitted:

  1. invalid-name:
    Constant name "_AllReceivers" doesn't conform to UPPER_CASE naming style
    https://github.com/getsentry/sentry/blob/6f4fa68a88493fe8dfed7b528bc6ff8cf7dd78ac/src/sentry/signals.py#L15
  2. invalid-name:
    Constant name "_EmptyType" doesn't conform to UPPER_CASE naming style
    https://github.com/getsentry/sentry/blob/6f4fa68a88493fe8dfed7b528bc6ff8cf7dd78ac/src/sentry/utils/lazy_service_wrapper.py#L14
  3. invalid-name:
    Constant name "ScrubbedData" doesn't conform to UPPER_CASE naming style
    https://github.com/getsentry/sentry/blob/6f4fa68a88493fe8dfed7b528bc6ff8cf7dd78ac/src/sentry/backup/comparators.py#L28
  4. invalid-name:
    Constant name "_UnsetType" doesn't conform to UPPER_CASE naming style
    https://github.com/getsentry/sentry/blob/6f4fa68a88493fe8dfed7b528bc6ff8cf7dd78ac/src/sentry/auth/superuser.py#L77
  5. invalid-name:
    Constant name "_UnsetType" doesn't conform to UPPER_CASE naming style
    https://github.com/getsentry/sentry/blob/6f4fa68a88493fe8dfed7b528bc6ff8cf7dd78ac/src/sentry/auth/staff.py#L46

This comment was generated for commit 939d6a7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport maintenance/4.0.x False Positive 🦟 A message is emitted but nothing is wrong with the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

invalid-name false-positive on Enum functional syntax on pylint v4

1 participant