Add tests for NewType false positives #5542
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colatkinson
force-pushed
the
fix-newtype
branch
from
58436c6 to
7b3c84c
Compare
Pierre-Sassoulas
added
the
Needs astroid update
Pierre-Sassoulas
added
the
False Positive 🦟
colatkinson
force-pushed
the
fix-newtype
branch
from
7b3c84c to
c168b7a
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Adds tests for false positives related to
typing.NewType. Specifically, in the contexts of member checking and iterability checking.Note that the fix itself is at pylint-dev/astroid#1301 -- these won't pass until that's merged.
Closes #2296
Closes #3162