-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Improve non ascii checker #5643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Pierre-Sassoulas
merged 17 commits into
pylint-dev:main
from
CarliJoy:improve_non_ascii_checker
Jan 10, 2022
Merged
Changes from 2 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
df77a71
improve non-ascii check
CarliJoy 7c0411a
split ``non-ascii-name`` into 3 different msgs
CarliJoy 54709b8
Apply suggestions from code review
CarliJoy c36c1eb
Keep the original message name
CarliJoy 1a0fed3
simplify checker
CarliJoy 737d51c
Apply suggestions from code review
CarliJoy 58524ce
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] bcc8a39
Do not change original files, use simple args check
CarliJoy 8ae2ab9
Merge branch 'improve_non_ascii_checker' of https://github.com/CarliJ…
CarliJoy 85f7529
fix functional test
CarliJoy 06761c8
Remove not needed unit tests
CarliJoy c89a5c8
update help
CarliJoy 4575edc
remove confidence as parameter
CarliJoy b22c2da
be more explicit in error message
CarliJoy e2c9a88
fix name
CarliJoy f6b540c
Apply suggestions from code review
CarliJoy 5ed79c7
add missing human-readable type
CarliJoy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.