Skip to content

Fix #5569: Fix a crash in unused-private-member when type(self) used in bound methods #5662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 11, 2022
Merged

Fix #5569: Fix a crash in unused-private-member when type(self) used in bound methods #5662

merged 2 commits into from
Jan 11, 2022

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
✓ 🐛 Bug fix

Description

Closes #5569

@coveralls
Copy link

coveralls commented Jan 11, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1682905954

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 93.765%
Totals Coverage Status
Change from base Build 1679862235: 0.02%
Covered Lines: 14481
Relevant Lines: 15444
💛 - Coveralls

DanielNoord
DanielNoord requested changes Jan 11, 2022
View reviewed changes
Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some questions about typing. I like to add typing to these class methods when I add to them as it slowly contributes to getting all of our code typed 😄

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job !

@Pierre-Sassoulas Pierre-Sassoulas merged commit 642268f into pylint-dev:main Jan 11, 2022
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.13.0 milestone Jan 11, 2022
@Pierre-Sassoulas Pierre-Sassoulas added the Crash 💥 A bug that makes pylint crash label Jan 11, 2022
@jacobtylerwalls jacobtylerwalls deleted the type-self-method branch January 11, 2022 15:55
@cdce8p cdce8p mentioned this pull request Mar 26, 2022
Closed
@jacobtylerwalls jacobtylerwalls mentioned this pull request Mar 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

@DanielNoord DanielNoord DanielNoord approved these changes

Assignees
No one assigned
Labels
Crash 💥 A bug that makes pylint crash
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.

Crash 'Call' object has no attribute 'name' when accessing a private class variable
4 participants
@jacobtylerwalls @coveralls @Pierre-Sassoulas @DanielNoord