Remove unnecessary try...except from frame() call
#5664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielNoord
added
the
Maintenance
2 tasks
Pull Request Test Coverage Report for Build 1682733845
💛 - Coveralls |
Pierre-Sassoulas
added
the
Needs review 🔍
cdce8p
approved these changes
Jan 30, 2022
There was a problem hiding this comment.
LGTM! Thanks @DanielNoord
As mentioned here: #5621 (comment), it's better to surface the error than to ignore it silently.
cdce8p
removed
the
Needs review 🔍
Pierre-Sassoulas
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Follow-up to #5621 (comment).
Discussion had not actually resolved, but wanted to create the PR so that we can merge it immediately after we have resolved.