Skip to content

Follow-up to some test changes #5685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 15, 2022
Merged

Follow-up to some test changes #5685

merged 2 commits into from
Jan 15, 2022

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
✓ 🔨 Refactoring

Description

We're getting some pytest warnings on main. This fixes that as well using the standard pattern for test files.

@DanielNoord DanielNoord added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Jan 15, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1701126915

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.006%) to 93.835%
Files with Coverage Reduction New Missed Lines %
pylint/testutils/checker_test_case.py 1 93.75%
Totals Coverage Status
Change from base Build 1701080697: -0.006%
Covered Lines: 14687
Relevant Lines: 15652
💛 - Coveralls

@DanielNoord
Copy link
Collaborator Author

That's actually quite a nice line to lose coverage 😄

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Jan 15, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap, nice to see this line gone from the coverage !😄

@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.13.0 milestone Jan 15, 2022
@Pierre-Sassoulas Pierre-Sassoulas merged commit 981cf9b into pylint-dev:main Jan 15, 2022
@DanielNoord DanielNoord deleted the test-warnings branch January 15, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielNoord @coveralls @Pierre-Sassoulas