Skip to content

Fix typing of get_node_first_ancestor_of_type() and related method #5686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2022

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

Discussed at #5684 (comment)

@DanielNoord DanielNoord added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Jan 15, 2022
@DanielNoord DanielNoord added this to the 2.13.0 milestone Jan 15, 2022
@jacobtylerwalls jacobtylerwalls changed the title Fix typing of get_node_first_ancestor_type() and related method Fix typing of get_node_first_ancestor_of_type() and related method Jan 15, 2022
@jacobtylerwalls
Copy link
Member Author

Maybe a squash and a rename would fix the typo in the commit msg? Should read of_ type.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1701961085

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 93.835%

Files with Coverage Reduction New Missed Lines %
pylint/lint/parallel.py 2 94.03%
Totals Coverage Status
Change from base Build 1701162975: -0.01%
Covered Lines: 14687
Relevant Lines: 15652

πŸ’› - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas merged commit fdd71ee into pylint-dev:main Jan 15, 2022
@jacobtylerwalls jacobtylerwalls deleted the fix-typing branch January 15, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants