Fix #5568: Allow nested classes as return annotations #5688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
commented
Jan 16, 2022
| maybe_before_assign = False | ||
| annotation_return = True | ||
| if ( | ||
| frame.returns.name in defframe.locals |
There was a problem hiding this comment.
The only substantive change in the PR is to change defframe.name to frame.returns.name. The rest is just refactoring for readability and avoiding re-checking the same boolean maybe_before_assign.
Pull Request Test Coverage Report for Build 1704780241
💛 - Coveralls |
Pierre-Sassoulas
added
the
False Positive 🦟
Pierre-Sassoulas
approved these changes
Jan 16, 2022
Co-authored-by: Pierre Sassoulas <[email protected]>
for more information, see https://pre-commit.ci
DanielNoord
approved these changes
Jan 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
The
undefined-variablechecker had a special case for return annotations matching the name of the containing class, but this missed other nested classes like anamedtupleused as a class attribute.Closes #5568