Skip to content

Fixed false positive for global-variable-undefined #5690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 17, 2022
Merged

Fixed false positive for global-variable-undefined #5690

merged 2 commits into from
Jan 17, 2022

Conversation

mbyrnepr2
Copy link
Member

Fixed false positive for global-variable-undefined when global is used with a class name

Type of Changes

Type
✓ 🐛 Bug fix
✨ New feature
🔨 Refactoring
📜 Docs

Description

Closes #3088

@Pierre-Sassoulas Pierre-Sassoulas added the False Positive 🦟 A message is emitted but nothing is wrong with the code label Jan 16, 2022
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.13.0 milestone Jan 16, 2022
@coveralls
Copy link

coveralls commented Jan 16, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1707227700

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.84%
Totals Coverage Status
Change from base Build 1705275093: 0.0%
Covered Lines: 14701
Relevant Lines: 15666
💛 - Coveralls

@mbyrnepr2 mbyrnepr2 marked this pull request as ready for review January 16, 2022 22:28
Pierre-Sassoulas
Pierre-Sassoulas approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very nice change. I think there's a little rebase issue, I'm going to handle this myself.

@Pierre-Sassoulas Pierre-Sassoulas merged commit f2c4e35 into pylint-dev:main Jan 17, 2022
@mbyrnepr2 mbyrnepr2 deleted the false_positive_global_variable_undefined branch January 17, 2022 10:14
@DanielNoord DanielNoord mentioned this pull request Feb 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

@DanielNoord DanielNoord DanielNoord approved these changes

Assignees
No one assigned
Labels
False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.

Analysis of "global" statements doesn't believe in classes
4 participants
@mbyrnepr2 @coveralls @Pierre-Sassoulas @DanielNoord