Skip to content

Fix end position in unittests #5904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2022
Merged

Fix end position in unittests #5904

merged 2 commits into from
Mar 12, 2022

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
✓ 🔨 Refactoring

Description

Follow up to #5897. I did not update these tests in that PR as it was not necessary (we only raise a DeprecationWarning for unittests with incorrect end positions).

@DanielNoord DanielNoord added this to the 2.13.0 milestone Mar 12, 2022
@DanielNoord DanielNoord added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Mar 12, 2022
@coveralls
Copy link

coveralls commented Mar 12, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1974122418

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.0007%) to 94.044%
Totals Coverage Status
Change from base Build 1974040115: -0.0007%
Covered Lines: 15047
Relevant Lines: 16000
💛 - Coveralls

@DanielNoord
Copy link
Collaborator Author

I'm going to add a # pragma: no cover to those warning functions 😄

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Mar 12, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Pierre-Sassoulas Pierre-Sassoulas merged commit 29480d4 into pylint-dev:main Mar 12, 2022
@DanielNoord DanielNoord deleted the position branch March 12, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielNoord @coveralls @Pierre-Sassoulas