Add regression test for #5771 #5908
Merged
+29
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
commented
Mar 13, 2022
| argnames = list( | ||
| itertools.chain(node.argnames(), [arg.name for arg in node.args.kwonlyargs]) | ||
| ) | ||
| argnames = node.argnames() |
There was a problem hiding this comment.
We discussed leveraging the changes in astroid to simplify this here: #5771 (comment)
There was a problem hiding this comment.
Pretty nice simplification !
Pull Request Test Coverage Report for Build 1975120334
💛 - Coveralls |
Pierre-Sassoulas
approved these changes
Mar 13, 2022
| argnames = list( | ||
| itertools.chain(node.argnames(), [arg.name for arg in node.args.kwonlyargs]) | ||
| ) | ||
| argnames = node.argnames() |
There was a problem hiding this comment.
Pretty nice simplification !
Pierre-Sassoulas
added
Astroid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #5771
Refs pylint-dev/astroid#1382
Pardon me if this shouldn't go in 2.13! I just noticed no regression test PR for it yet, even though it's already fixed. Feel free to bump the milestone.