Skip to content

Upgrade and cleanup the contributors txt #5909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 13, 2022

Conversation

Pierre-Sassoulas
Copy link
Member

Type of Changes

Type
✨ New feature
🔨 Refactoring
📜 Docs

Description

Necessary for #5877, separated for clarity.

@Pierre-Sassoulas Pierre-Sassoulas added Documentation 📗 Maintenance Discussion or action around maintaining pylint or the dev workflow labels Mar 13, 2022
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.13.0 milestone Mar 13, 2022
CONTRIBUTORS.txt Outdated
- Bryce Guinta <bryce.paul.guinta@gmail.com>
- Jacob Walls <jacobtylerwalls@gmail.com>
- Dimitri Prybysh <dmand@yandex.ru>
- multiple-imports, not-iterable, not-a-mapping, various patches.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in terms of parse ability, do want this to be a * or something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering is we should not instead add a link to : https://github.com/PyCQA/pylint/pulls/areveny

We'd need a "database" mail => github handles though. But this would be highly automatable and up to date...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be possible to get that info based on GitHub's rest API. But that's really something for the future, as in, there are more pressing matters.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review commit by commits the new global diff will probably be horrendous. I hesitated to create another PR but let's keep it simple 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CONTRIBUTORS.txt Outdated
@@ -107,7 +102,7 @@ contributors:

* Aru Sahni: Git ignoring, regex-based ignores

* Mike Frysinger: contributor.
* Mike Frysinger
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the contributing documentation. That says something about adding your names here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to really automate in #5877 so I'll update there.

@coveralls
Copy link

coveralls commented Mar 13, 2022

Pull Request Test Coverage Report for Build 1975863611

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.051%

Totals Coverage Status
Change from base Build 1975573227: 0.0%
Covered Lines: 15066
Relevant Lines: 16019

💛 - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas merged commit 7981ec0 into main Mar 13, 2022
@Pierre-Sassoulas Pierre-Sassoulas deleted the simplify-contributors-txt branch March 13, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation 📗 Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants