-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Upgrade and cleanup the contributors txt
#5909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CONTRIBUTORS.txt
Outdated
- Bryce Guinta <bryce.paul.guinta@gmail.com> | ||
- Jacob Walls <jacobtylerwalls@gmail.com> | ||
- Dimitri Prybysh <dmand@yandex.ru> | ||
- multiple-imports, not-iterable, not-a-mapping, various patches. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just in terms of parse ability, do want this to be a *
or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering is we should not instead add a link to : https://github.com/PyCQA/pylint/pulls/areveny
We'd need a "database" mail => github handles though. But this would be highly automatable and up to date...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be possible to get that info based on GitHub's rest API. But that's really something for the future, as in, there are more pressing matters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review commit by commits the new global diff will probably be horrendous. I hesitated to create another PR but let's keep it simple 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CONTRIBUTORS.txt
Outdated
@@ -107,7 +102,7 @@ contributors: | |||
|
|||
* Aru Sahni: Git ignoring, regex-based ignores | |||
|
|||
* Mike Frysinger: contributor. | |||
* Mike Frysinger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update the contributing documentation. That says something about adding your names here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to really automate in #5877 so I'll update there.
Pull Request Test Coverage Report for Build 1975863611
💛 - Coveralls |
Type of Changes
Description
Necessary for #5877, separated for clarity.