Skip to content

Update typing-extensions requirement from ~=4.0 to ~=4.1 #5912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2022
Merged

Update typing-extensions requirement from ~=4.0 to ~=4.1 #5912

merged 1 commit into from
Mar 15, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 14, 2022

Updates the requirements on typing-extensions to permit the latest version.

Changelog

Sourced from typing-extensions's changelog.

Release 4.1.1 (February 13, 2022)

  • Fix importing typing_extensions on Python 3.7.0 and 3.7.1. Original patch by Nikita Sobolev (@​sobolevn).

Release 4.1.0 (February 12, 2022)

  • Runtime support for PEP 646, adding typing_extensions.TypeVarTuple and typing_extensions.Unpack.
  • Add interaction of Required and NotRequired with __required_keys__, __optional_keys__ and get_type_hints(). Patch by David Cabot (@​d-k-bo).
  • Runtime support for PEP 675 and typing_extensions.LiteralString.
  • Add Never and assert_never. Backport from bpo-46475.
  • ParamSpec args and kwargs are now equal to themselves. Backport from bpo-46676. Patch by Gregory Beauregard (@​GBeauregard).
  • Add reveal_type. Backport from bpo-46414.
  • Runtime support for PEP 681 and typing_extensions.dataclass_transform.
  • Annotated can now wrap ClassVar and Final. Backport from bpo-46491. Patch by Gregory Beauregard (@​GBeauregard).
  • Add missed Required and NotRequired to __all__. Patch by Yuri Karabas (@​uriyyo).
  • The @final decorator now sets the __final__ attribute on the decorated object to allow runtime introspection. Backport from bpo-46342.
  • Add is_typeddict. Patch by Chris Moradi (@​chrismoradi) and James Hilton-Balfe (@​Gobot1234).

Release 4.0.1 (November 30, 2021)

  • Fix broken sdist in release 4.0.0. Patch by Adam Turner (@​AA-Turner).
  • Fix equality comparison for Required and NotRequired. Patch by Jelle Zijlstra (@​jellezijlstra).
  • Fix usage of Self as a type argument. Patch by Chris Wesseling (@​CharString) and James Hilton-Balfe (@​Gobot1234).

Release 4.0.0 (November 14, 2021)

  • Starting with version 4.0.0, typing_extensions uses Semantic Versioning. See the README for more information.
  • Dropped support for Python versions 3.5 and older, including Python 2.7.
  • Simplified backports for Python 3.6.0 and newer. Patch by Adam Turner (@​AA-Turner).

Added in version 4.0.0

  • Runtime support for PEP 673 and typing_extensions.Self. Patch by James Hilton-Balfe (@​Gobot1234).
  • Runtime support for PEP 655 and typing_extensions.Required and NotRequired. Patch by David Foster (@​davidfstr).

Removed in version 4.0.0

... (truncated)

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
Update typing-extensions requirement from ~=4.0 to ~=4.1
6b36ded 
Updates the requirements on [typing-extensions](https://github.com/python/typing) to permit the latest version.
- [Release notes](https://github.com/python/typing/releases)
- [Changelog](https://github.com/python/typing/blob/master/typing_extensions/CHANGELOG)
- [Commits](python/typing@4.0.0...4.1.1)

---
updated-dependencies:
- dependency-name: typing-extensions
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependency Label for github dependabot label Mar 14, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1980712037

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.051%
Totals Coverage Status
Change from base Build 1977638875: 0.0%
Covered Lines: 15066
Relevant Lines: 16019
💛 - Coveralls

@DanielNoord
Copy link
Collaborator

In setup.cfg we don't pin this. Should we also unpin for the tests?

@Pierre-Sassoulas
Copy link
Member

I think it's a way to check that new version of dependency do not break the tests. If we unpin we could have the main branch fail suddenly because a new release broke it. (Well,if it's not pinned in setup.cfg the released pylint itself could break too which admittedly is worse)

@Pierre-Sassoulas
Copy link
Member

Shouldn't we have a pretty large acceptable range for this one by the way ? It's causing problem with other installed libraries very easily. (Pylint was impossible to install with tensortflow from 2.5 to 2.7, a pretty long time for example).

@DanielNoord
Copy link
Collaborator

I think we should add at least a lower bound in setup.cfg then.

@Pierre-Sassoulas
Copy link
Member

Do you have an idea how we can find the lowest bound ? Otherwise we could do >=good enough lower bound,<5.

@DanielNoord
Copy link
Collaborator

Do you have an idea how we can find the lowest bound ? Otherwise we could do >=good enough lower bound,<5.

Should be a process of running the test suite a couple of times. I might find the time to do that somewhere next week!

@Pierre-Sassoulas
Copy link
Member

All right, if we're doing it empirically I think testing >2,<3, >3,<4, and >4,<5 are probably enough.

@DanielNoord
Copy link
Collaborator

I wasn't sharp yesterday it seems. We actually do pin typing-extensions>=3.10.0;python_version<"3.10". This is correct.

We probably don't need an upper bound as typing-extensions is really careful about breaking changes. They have switched to semversioning for 4.x, but I don't expect many breaking changes in the future (they just back port Python typing stuff).

@DanielNoord DanielNoord added this to the 2.13.0 milestone Mar 15, 2022
@DanielNoord DanielNoord merged commit fcc17e9 into main Mar 15, 2022
@DanielNoord DanielNoord deleted the dependabot/pip/typing-extensions-approx-eq-4.1 branch March 15, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielNoord DanielNoord DanielNoord approved these changes

Assignees
No one assigned
Labels
dependency Label for github dependabot
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@coveralls @DanielNoord @Pierre-Sassoulas