-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Handle ComprehensionScope
and their behaviour better
#5923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 1988874403
π - Coveralls |
@Pierre-Sassoulas I didn't expect this, but the tests seem to pass (with expected drop in coverage). If we can get confirmation on the approach taken in pylint-dev/astroid#1475 we can get this in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could merge directly for 2.13.0, after investigation of the coverage change ? Imo the code in pylint never considered that the comprehension scope could be something else than uninferrable because it never was, but this is not a voluntary design choice.
The coverage change is just two |
@Pierre-Sassoulas I have added some TODOs so that if for some unforeseen reason we don't merge the |
CONTRIBUTORS.txt
if you are a new contributor.Type of Changes
Description
Refactoring necessary for pylint-dev/astroid#1475 to be "acceptable" for
pylint
.Note that the change to
names_hint = ", ".join(names)
might be unrelated, but I couldn't getpre-commit
to pass without it and I wanted to show that if you clone pylint-dev/astroid#1475 and these changes then both test suites should pass.