Skip to content

Better configuration for duplicate email/name in the contributors #5927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 23, 2022

Conversation

Pierre-Sassoulas
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas commented Mar 16, 2022

Type of Changes

Type
βœ“ πŸ”¨ Refactoring
βœ“ πŸ“œ Docs

Description

Separating the work from #5877 in two MR. @DanielNoord

We need to find duplicate of email and name in the shortlog.

For example 'frostming' has a duplicate as I open this MR

- Frost Ming <[email protected]> (frostming <[email protected]>)

Needs a conf like:

  "[email protected]": {
    "mails": ["[email protected]", "[email protected]"],
    "name": "Frost Ming"
  }

So we treat it properly.

@Pierre-Sassoulas Pierre-Sassoulas added Documentation πŸ“— Work in progress Maintenance Discussion or action around maintaining pylint or the dev workflow labels Mar 16, 2022
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.13.0 milestone Mar 16, 2022
@coveralls
Copy link

coveralls commented Mar 16, 2022

Pull Request Test Coverage Report for Build 2029946868

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.102%

Totals Coverage Status
Change from base Build 2024294567: 0.0%
Covered Lines: 15205
Relevant Lines: 16158

πŸ’› - Coveralls

@DanielNoord
Copy link
Collaborator

@Pierre-Sassoulas I just changed the script/.contributors_aliases.json format for now to use the correct key:value pairs.

Had you thought about how you want to store the information from the * ....... lines? Will that be in the aliases file? Currently if you regenerate CONTRIBUTORS it will be removed.

@Pierre-Sassoulas
Copy link
Member Author

At first I assumed name was unique, but it's not, we have a "Carl" for example. So I use email now and it permits to change the name if we have the email. At least the email should be unique unless someone is not using a real email (it happens too). I'm afraid we're going to have to throw away some contributions with a bad name and no email (or [email protected]). To uniformize the config file I use : contributors-txt-normalize-configuration -a scripts/.contributors_aliases.json -o scripts/.contributors_aliases.json (then pre-commit). There a check for unicity of email here : https://github.com/Pierre-Sassoulas/contributors-txt/blob/main/contributors_txt/create_content.py#L78.

@DanielNoord
Copy link
Collaborator

Ah okay, I'll let you handle this then. No point in having two captains on one ship πŸ˜„

@Pierre-Sassoulas Pierre-Sassoulas force-pushed the better-contributors.txt-semi-manually branch 2 times, most recently from e9a3f28 to ee8a810 Compare March 23, 2022 18:05
@Pierre-Sassoulas Pierre-Sassoulas force-pushed the better-contributors.txt-semi-manually branch from ee8a810 to 9c3d97f Compare March 23, 2022 18:16
@Pierre-Sassoulas Pierre-Sassoulas merged commit 8083874 into main Mar 23, 2022
@Pierre-Sassoulas Pierre-Sassoulas deleted the better-contributors.txt-semi-manually branch March 23, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation πŸ“— Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants