-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Better configuration for duplicate email/name in the contributors #5927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 2029946868
π - Coveralls |
@Pierre-Sassoulas I just changed the Had you thought about how you want to store the information from the |
At first I assumed name was unique, but it's not, we have a "Carl" for example. So I use email now and it permits to change the name if we have the email. At least the email should be unique unless someone is not using a real email (it happens too). I'm afraid we're going to have to throw away some contributions with a bad name and no email (or [email protected]). To uniformize the config file I use : |
Ah okay, I'll let you handle this then. No point in having two captains on one ship π |
e9a3f28
to
ee8a810
Compare
I.E. the used name in git is the same that was already existing in the contributors.txt.
ee8a810
to
9c3d97f
Compare
Type of Changes
Description
Separating the work from #5877 in two MR. @DanielNoord
We need to find duplicate of email and name in the shortlog.
For example 'frostming' has a duplicate as I open this MR
- Frost Ming <[email protected]> (frostming <[email protected]>)
Needs a conf like:
So we treat it properly.