Skip to content

Emit using-constant-test when testing truth value of a variable holding a generator #6916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 12, 2022

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
✨ New feature

Description

Refs #6909

@jacobtylerwalls jacobtylerwalls added the Enhancement ✨ Improvement to a component label Jun 11, 2022
@jacobtylerwalls jacobtylerwalls added this to the 2.15.0 milestone Jun 11, 2022
@coveralls
Copy link

coveralls commented Jun 11, 2022

Pull Request Test Coverage Report for Build 2484521878

  • 23 of 24 (95.83%) changed or added relevant lines in 1 file are covered.
  • 17 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.0004%) to 95.528%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pylint/checkers/base/basic_checker.py 23 24 95.83%
Files with Coverage Reduction New Missed Lines %
pylint/checkers/variables.py 17 96.61%
Totals Coverage Status
Change from base Build 2483524984: -0.0004%
Covered Lines: 16407
Relevant Lines: 17175

💛 - Coveralls

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great !

@@ -26,3 +26,5 @@ using-constant-test:89:3:89:15::Using a conditional statement with a constant va
using-constant-test:93:3:93:18::Using a conditional statement with a constant value:INFERENCE
comparison-of-constants:117:3:117:8::"Comparison between constants: '2 < 3' has a constant value":HIGH
using-constant-test:156:0:157:8::Using a conditional statement with a constant value:INFERENCE
using-constant-test:168:3:168:4::Using a conditional statement with a constant value:UNDEFINED
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message has confidence "undefined", it's a little strange but we can merge anyway, I'm just pointing it out in case you did not notice.

@github-actions
Copy link
Contributor

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 3e66e2b

@jacobtylerwalls jacobtylerwalls merged commit 003b472 into pylint-dev:main Jun 12, 2022
@jacobtylerwalls jacobtylerwalls deleted the gen-exp-follow-up branch June 12, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement ✨ Improvement to a component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants