-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Emit using-constant-test
when testing truth value of a variable holding a generator
#6916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit using-constant-test
when testing truth value of a variable holding a generator
#6916
Conversation
…ding a generator
Pull Request Test Coverage Report for Build 2484521878
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great !
@@ -26,3 +26,5 @@ using-constant-test:89:3:89:15::Using a conditional statement with a constant va | |||
using-constant-test:93:3:93:18::Using a conditional statement with a constant value:INFERENCE | |||
comparison-of-constants:117:3:117:8::"Comparison between constants: '2 < 3' has a constant value":HIGH | |||
using-constant-test:156:0:157:8::Using a conditional statement with a constant value:INFERENCE | |||
using-constant-test:168:3:168:4::Using a conditional statement with a constant value:UNDEFINED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This message has confidence "undefined", it's a little strange but we can merge anyway, I'm just pointing it out in case you did not notice.
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 3e66e2b |
Type of Changes
Description
Refs #6909