Skip to content

Rename useless-super-delegation to useless-parent-delegation #6955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 24, 2022
Merged

Rename useless-super-delegation to useless-parent-delegation #6955

merged 3 commits into from
Jun 24, 2022

Conversation

Pierre-Sassoulas
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas commented Jun 15, 2022 •
edited
Loading

Type of Changes

Type
✓ 🐛 Bug fix
✓ ✨ New feature
✓ 🔨 Refactoring
✓ 📜 Docs

Description

Closes #6953

@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Jun 15, 2022
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.15.0 milestone Jun 15, 2022
Pierre-Sassoulas
Pierre-Sassoulas commented Jun 15, 2022
View reviewed changes
pylint/checkers/classes/class_checker.py
"from the MRO.",
{"old_names": [("W0235", "useless-super-delegation")]},
Copy link
Member Author

@Pierre-Sassoulas Pierre-Sassoulas Jun 15, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a tuple here trip up the check for consider-using-namedtuple-or-dataclass for the whole surrounding dict.

@coveralls
Copy link

coveralls commented Jun 15, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2554373190

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.339%
Totals Coverage Status
Change from base Build 2553793664: 0.0%
Covered Lines: 16649
Relevant Lines: 17463
💛 - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas force-pushed the rename-useless-super-delegation branch 2 times, most recently from 4bf3f98 to 327dee9 Compare June 15, 2022 08:35
@github-actions

This comment has been minimized.

Sign in to view
@Pierre-Sassoulas Pierre-Sassoulas force-pushed the rename-useless-super-delegation branch from 327dee9 to 1769f7f Compare June 15, 2022 18:45
@github-actions

This comment has been minimized.

Sign in to view
DanielNoord
DanielNoord requested changes Jun 15, 2022
View reviewed changes
tests/functional/u/useless/useless_super_delegation.py Outdated
@@ -211,63 +211,63 @@ def with_default_unhandled(self, first, default_arg=lambda: True):

class UselessSuper(Base):

def equivalent_params(self): # [useless-super-delegation]
def equivalent_params(self): # [useless-parent-delegation]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably rename all test files.

@DanielNoord DanielNoord added the Waiting on author Indicate that maintainers are waiting for a message of the author label Jun 21, 2022
@github-actions

This comment has been minimized.

Sign in to view
@Pierre-Sassoulas
[useless-parent-delegation] Rename functional test and merge old files
f620214 
We don't need specific file for python 3.0 or 3.5 nowaydays
@Pierre-Sassoulas Pierre-Sassoulas force-pushed the rename-useless-super-delegation branch from c2a859d to f620214 Compare June 24, 2022 08:00
@Pierre-Sassoulas Pierre-Sassoulas removed the Waiting on author Indicate that maintainers are waiting for a message of the author label Jun 24, 2022
@github-actions
Copy link
Contributor

🤖 Effect of this PR on checked open source code: 🤖

Effect on pandas:
The following messages are now emitted:

  1. useless-parent-delegation:
    Useless parent or super() delegation in method 'test_groupby_extension_apply'
    https://github.com/pandas-dev/pandas/blob/main/pandas/tests/extension/test_numpy.py#L230
  2. useless-parent-delegation:
    Useless parent or super() delegation in method 'test_setitem_mask_raises'
    https://github.com/pandas-dev/pandas/blob/main/pandas/tests/extension/test_numpy.py#L397
  3. useless-parent-delegation:
    Useless parent or super() delegation in method 'test_groupby_agg_extension'
    https://github.com/pandas-dev/pandas/blob/main/pandas/tests/extension/decimal/test_decimal.py#L161
  4. useless-parent-delegation:
    Useless parent or super() delegation in method 'unique'
    https://github.com/pandas-dev/pandas/blob/main/pandas/core/series.py#L2064
  5. useless-parent-delegation:
    Useless parent or super() delegation in method 'apply_broadcast'
    https://github.com/pandas-dev/pandas/blob/main/pandas/core/apply.py#L926
  6. useless-parent-delegation:
    Useless parent or super() delegation in method 'view'
    https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/datetimelike.py#L518

The following messages are no longer emitted:

  1. useless-super-delegation:
    Useless super delegation in method 'test_groupby_extension_apply'
    https://github.com/pandas-dev/pandas/blob/main/pandas/tests/extension/test_numpy.py#L230
  2. useless-super-delegation:
    Useless super delegation in method 'test_setitem_mask_raises'
    https://github.com/pandas-dev/pandas/blob/main/pandas/tests/extension/test_numpy.py#L397
  3. useless-super-delegation:
    Useless super delegation in method 'test_groupby_agg_extension'
    https://github.com/pandas-dev/pandas/blob/main/pandas/tests/extension/decimal/test_decimal.py#L161
  4. useless-super-delegation:
    Useless super delegation in method 'unique'
    https://github.com/pandas-dev/pandas/blob/main/pandas/core/series.py#L2064
  5. useless-super-delegation:
    Useless super delegation in method 'apply_broadcast'
    https://github.com/pandas-dev/pandas/blob/main/pandas/core/apply.py#L926
  6. useless-super-delegation:
    Useless super delegation in method 'view'
    https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/datetimelike.py#L518

Effect on sentry:
The following messages are now emitted:

  1. useless-parent-delegation:
    Useless parent or super() delegation in method '_post_teardown'
    https://github.com/getsentry/sentry/blob/master/src/sentry/testutils/cases.py#L288

The following messages are no longer emitted:

  1. useless-super-delegation:
    Useless super delegation in method '_post_teardown'
    https://github.com/getsentry/sentry/blob/master/src/sentry/testutils/cases.py#L288

This comment was generated for commit f620214

@Pierre-Sassoulas Pierre-Sassoulas merged commit b154311 into pylint-dev:main Jun 24, 2022
@Pierre-Sassoulas Pierre-Sassoulas deleted the rename-useless-super-delegation branch June 24, 2022 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielNoord DanielNoord DanielNoord approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.

Rename useless-super-delegation to useless-parent-delegation
3 participants
@Pierre-Sassoulas @coveralls @DanielNoord